[HOLD for payment 2023-07-17] Chat -App crash after remove the member

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. From userA, go to Settings > Workspaces
2. Click on New workspace button
3. Go to the #announce room and send a message
4. Click on the room header
5. Go to Settings > Welcome message
6. Add any message and click on the save button
7. Go to Settings > Workspaces >Members > Invite
8. Invite userB
9. From userB, go to #announce
10. Hover over welcome message > click reply in thread option > 11. send a message in thread
11. From userA, remove the userB from workspace

Expected Result:

App should not crash

Actual Result:

App crash for userB

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37-3
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-06.at.9.59.35.PM.mov

Recording.3452.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688661191934669

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Julesssss]

Hey @cead22, this is one of like 9 App blockers today and it occurred too late in the day for me to triage or work on it. I would appreciate it if you're able to triage and maybe look for the PR that introduced the regression (if that is the case).

Then I can pick this up tomorrow early UK time 👍

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes after remove member

What is the root cause of that problem?

Cash happens on this line:

App/src/libs/ReportUtils.js

Lines 477 to 479 in 01a18f0

	if (report === undefined) {
	return noPolicyFound;
	}

So after user is removed from policy, report is set to null, not undefined so it doesn't return early

What changes do you think we should make in order to solve the problem?

Update condition to

 if (!report) {

or

 if (_.isEmpty(report)) {

[cead22]

Looks like that was introduced in this PR, cc @chiragsalian

[chiragsalian]

Technically i think my PR didn't introduce that crash because if you remove this block that i added it would still crash.

So technically crash could not happen on that line because if report is set to null it would never enter that block linked above.

But yes i agree with the changes. I personally prefer isEmpty. Are you creating the PR @cead22 or shall i?

[situchan]

I am available right now to raise PR 🙂

[chiragsalian]

Neat, i'll defer to @cead22 to decide if you should create the PR since he's assigned so I'm not sure if he's already started working on it.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix crash on whisper thread after remove member #22360

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix crash on whisper thread after remove member #22360

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[lschurr]

@gadhiyamanan @situchan - can you apply here? https://www.upwork.com/jobs/~019e655fd4b52e872f

[gadhiyamanan]

@lschurr can you send me an offer, i don't have connects to apply

[situchan]

@gadhiyamanan @situchan - can you apply here? https://www.upwork.com/jobs/~019e655fd4b52e872f

[situchan]

If you can send direct offer, that would be much appreciated.
profile link: https://www.upwork.com/freelancers/~01223f6e853d3d82b4

[lschurr]

Could you both put your Upwork profile here?

[gadhiyamanan]

@lschurr here's my profile link : https://www.upwork.com/freelancers/~01b6fd34f946454a68

[lschurr]

Great, I've sent invites to you both.

[gadhiyamanan]

@lschurr applied, thanks!

[situchan]

Great, I've sent invites to you both.

Accepted, thanks

[situchan]

@lschurr I maybe eligible for speed bonus as well

[lschurr]

I think since this was a minor change, we would only pay the base pay - @chiragsalian - do you have thoughts on this?

[lschurr]

Issued the bonus. All paid. Closing this one out.