[HOLD for payment 2023-07-24] [$1000] Unable to Upload PDF & JPEG files that contains a space in the file title

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. click plus button on the composer and upload a Password Protected PDF attachment with a space in the title (example below)
3. Observe the error, then dismiss the error
4. now attach a regular PDF that has a space in the title (example below)
5. Observe the error, then dismiss the error
6. now attach a PNG file that has a space in the title
7. Observe the error again

Expected Result:

able to upload file attachments that contain a space in the file name

Actual Result:

Unexpected error while posting the comment.

"Unexpected error while posting the comment, please try again later. Invalid file attachment"

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37-2
Reproducible in staging?: y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test54_Pdfupload-1.mp4

Recording.1163.mp4

Z1uG9cr94S.mp4

DATTARAM_SAWANT_AADHAR_CARD 1_.pdf

Example With Space.pdf

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688495589932239

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dc241c0a0b2ba919
• Upwork Job ID: 1676993011268341760
• Last Price Increase: 2023-07-06

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcochavezf]

I can't reproduce the issue with the provided pdf on both staging and dev (latest main):

[trjExpensify]

Me neither on staging mac chrome:

Let's take this to the thread, I've noticed a couple of things from the video:

1. It's windows not mac
2. the preview of the PDF is different than the one supplied

I don't think this is a deploy blocker.

[Julesssss]

Thanks both. I'm also unable to reproduce so I'm downgrading it from being an App release blocker. Also would be happy to just close it, based on the outcome of the thread discussions.

[trjExpensify]

Cool, sounds good. I've asked the contributor to retry once and supply that PDF before I close it out.

[kavimuru]

@trjExpensify This is happening to me inconsistently. One more contributor reproduced here

[dhanashree-sawant]

@trjExpensify, @Julesssss, I was able to recreate it consistently if I used password protected PDF with space in name and sent the PDF in offline mode. I was able to reproduce on mac too using it. Maybe this info can help.

[trjExpensify]

Requesting the file in slack to try and then include here!

[trjExpensify]

Okay, that'll do it! Either online or offline I get the same results with a password protected PDF which includes a space in the title.

[trjExpensify]

Okay, I can repro this with multiple file types that contain spaces in the name.

Z1uG9cr94S.mp4

[marcochavezf]

Thanks for the review @fedirjh, assigning @alitoshmatov 🚀

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @daveSeife 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[alitoshmatov]

PR ready - #22672

[alitoshmatov]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Looks like I didn't receive an offer in upwork, is there something I should do?

[daveSeife]

📣 @daveSeife 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

Accepted the offer, Thanks

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[trjExpensify]

We've still got the regression period to wait out, but @fedirjh can you confirm there was a regression from the PR that fixed this?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.41-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Uploading file with special characters, cleaning file name everywhere #22672

If no regressions arise, payment will be issued on 2023-07-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[fedirjh]

We've still got the regression period to wait out, but @fedirjh can you confirm there was a regression from the PR that fixed this?

@trjExpensify Yes there was a deploy blocker (regression) from the linked PR.

[trjExpensify]

Cool, thanks! Let's get to the checklist when you're ready :)

[trjExpensify]

Bump on the checklist, @fedirjh!

In the meantime, confirming these are the payments due to send the offers:

• No #urgency bonus to consider due to the regression.
• $500 to @alitoshmatov for the fix, reduced by 50% because of the regression.
• $500 to @fedirjh for C+, reduced by 50% because of the regression.
• $250 to @daveSeife for the bug report

[fedirjh]

BugZero Checklist:

• Link to the PR: Replace file names with underscore when they have slash / #14664 (comment) , the bug remains hidden until a backend changes was deployed to start validating files by their types.
• Link to comment: Replace file names with underscore when they have slash / #14664 (comment)
• Link to discussion: Not sure if we should start a discussion since the root cause comes from backend.
• Determine if we should create a regression test for this bug: I think we have a regression test that should have caught this issue , specifically this test : [HOLD for payment 2023-02-10] File name with "/" removes the extension and breaks the file when downloaded #14266 (comment) . I think there was a recent changes in the backend that caused this issue.

[trjExpensify]

Cool, that works for me!

Settled up with everyone, closing. Thanks!