-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-01-24] Remove RN patch once upstream PR38074 is merged #22155
Comments
holding |
Not merged yet |
soon should be ready to be removed |
@adamgrzybowski How is this one looking, what RN version should this be part of? |
@j-piasecki Will this patch be removed in the RN upgrade? Can I assign you if so and close this issue once we merge it? |
Yes, the PR with RN upgrade will also remove this patch.
Go ahead |
Thanks! |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
This was removed in the PR, closing |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-24. 🎊 For reference, here are some details about the assignees on this issue:
|
cc @adamgrzybowski
In this PR we have added a RN patch which fixed one bug #21124 and also created an upstream RN fix to get this out to the core codebase facebook/react-native#38074
Lets remove the patch once we update to new RN version including this fix.
The text was updated successfully, but these errors were encountered: