Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-24] Remove RN patch once upstream PR38074 is merged #22155

Closed
mountiny opened this issue Jul 4, 2023 · 11 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Task Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Jul 4, 2023

cc @adamgrzybowski

In this PR we have added a RN patch which fixed one bug #21124 and also created an upstream RN fix to get this out to the core codebase facebook/react-native#38074

Lets remove the patch once we update to new RN version including this fix.

@mountiny
Copy link
Contributor Author

mountiny commented Aug 6, 2023

holding

@melvin-bot melvin-bot bot removed the Overdue label Aug 6, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@mountiny
Copy link
Contributor Author

Not merged yet

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 13, 2023
@mountiny
Copy link
Contributor Author

soon should be ready to be removed

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@mountiny
Copy link
Contributor Author

@adamgrzybowski How is this one looking, what RN version should this be part of?

@melvin-bot melvin-bot bot removed the Overdue label Nov 24, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 26, 2023
@mountiny
Copy link
Contributor Author

@j-piasecki Will this patch be removed in the RN upgrade? Can I assign you if so and close this issue once we merge it?

@melvin-bot melvin-bot bot removed the Overdue label Dec 28, 2023
@j-piasecki
Copy link
Contributor

Yes, the PR with RN upgrade will also remove this patch.

Can I assign you if so and close this issue once we merge it?

Go ahead

@mountiny
Copy link
Contributor Author

Thanks!

Copy link

melvin-bot bot commented Jan 9, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Jan 11, 2024
@mountiny
Copy link
Contributor Author

This was removed in the PR, closing

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 15, 2024
@melvin-bot melvin-bot bot changed the title Remove RN patch once upstream PR38074 is merged [HOLD for payment 2024-01-24] Remove RN patch once upstream PR38074 is merged Jan 17, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 17, 2024
Copy link

melvin-bot bot commented Jan 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants