[HOLD for payment 2023-09-06] [$1000] mweb - Inconsistency: Copy Link context menu item does not show on the attachment message when it is opened over the attachment in mweb|web

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a DM with any user in NewDot.
2. Send a attachment message.
3. Long press over the attachment to open the context menu.

Expected Result:

On mweb, it should show copy link item as well when opened over the attachment same like native application.
We should either shown for both mWeb and native or hide on both. I think better would be to show it as there is less space for the user to open the full context menu for attachment(which is opened when user long presses the empty space side to the attachment).

Actual Result:

On mweb, copy link menu item is not shown when menu is opened over the attachment. This is inconsistent with the native iOS and Android.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28-3

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-16.at.2.07.06.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686904574870779

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0152b793902d18fd0b
• Upwork Job ID: 1673348174719672320
• Last Price Increase: 2023-07-17

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jeet-dhandha]

@kbecciv @flaviadefaria - This was disabled around this,
PR: #9955
Issue: #9660.
We were waiting to add a copy image to clipboard functionality but we aren't there yet probably.

If we want to be at a situation where user can identify between copy link of message and not mistake it for copy link of image. Then we can change Copy Link to Copy Message Link and remove the isAttachment check to show the Copy Message Link again.

[parasharrajat]

Good Find @jeet-dhandha. But this issue is a little different. In the linked PR we disabled the copy link menu for all platforms over the attachment but I noticed now, it is shown over the attachment on native but not on mweb.

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copy link menu item should be hidden when menu is opened over the attachment on mobile native application

What is the root cause of that problem?

We hide Copy Link menu by checking the tagName. For web apps, event.nativeEvent.target.tagName is set to 'IMG', but for native apps, it isn't. This is the root cause

What changes do you think we should make in order to solve the problem?

We can add the tagName field to the event manually

Replace this line

App/src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js

Line 63 in 7075414

onLongPress={(event) => showContextMenuForReport(event, anchor, report.reportID, action, checkIfContextMenuActive, ReportUtils.isArchivedRoom(report))}

with

        onLongPress={(event) => showContextMenuForReport(
            {nativeEvent: {...event.nativeEvent, target: {tagName: 'IMG'}}},
            anchor,
            report.reportID,
            action,
            checkIfContextMenuActive,
            ReportUtils.isArchivedRoom(report)
        )}

This works as expected.

Result

21346.mp4

What alternative solutions did you explore? (Optional)

[jeet-dhandha]

@parasharrajat Are we expecting copy link over here or are we still waiting to get a copy image and then allow it on image press ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0152b793902d18fd0b

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[flaviadefaria]

Added the external label. I agree with making this consistent for mWeb.

[jeet-dhandha]

@flaviadefaria - Any thoughts on this comment #21346 (comment) ?

[melvin-bot]

@flaviadefaria, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[flaviadefaria]

@jeet-dhandha I agree with you that adding copy link doesn't make sense. I actually posted here to understand a bit better the inconsistency reported as I couldn't find it.

[parasharrajat]

I checked Slack and they hide the copy link option on attachments also, they rename the menu item to copy link to message. For this issue,

So, I think mWeb is fine as it hides the copy link menu item over the attachment. We should do the same here on the Native platforms.

We can also rename the menu for native or mobile platforms if you think that should be done too. I don't have much context of this if it was discussed before or what was decided.

cc: @flaviadefaria

[0xmiros]

So, I think mWeb is fine as it hides the copy link menu item over the attachment. We should do the same here on the Native platforms.

I agree this is expected behavior for now and should be fixed in this GH.
Updating to Copy message link is more like a feature request.

Waiting for proposals...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[dummy-1111]

@0xmiroslav

Can you explain again what is the expected behavior of this issue?

[melvin-bot]

@youssef-lr, @flaviadefaria, @situchan, @s-alves10 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@youssef-lr, @flaviadefaria, @situchan, @s-alves10 Huh... This is 4 days overdue. Who can take care of this?

[situchan]

BZ Checklist:
No regression. This is inconsistency, not bug. As this is still beta feature, regression test is not needed for now.

[parasharrajat]

As this is still a beta feature, a regression test is not needed for now.

I don't think we should ignore the steps due to this reason. Or do you have any reference to some discussion where you confirmed this?

[situchan]

As this is still a beta feature, a regression test is not needed for now.

I don't think we should ignore the steps due to this reason. Or do you have any reference to some discussion where you confirmed this?

I don't have any reference. But this doesn't affect production users yet.
I don't think it's late to add regression test step after message deep link is implemented and beta is removed.

[flaviadefaria]

For reference, here are some details about the assignees on this issue:
@situchan requires payment
@s-alves10 requires payment
@parasharrajat does not require payment (Eligible for Manual Requests)

Payment Summary:

@situchan requires payment = $1000 (no bonus)
@s-alves10 requires payment = $1000 (no bonus)
@parasharrajat does not require payment (Eligible for Manual Requests) = $250 (reporting bonus)

[situchan]

@flaviadefaria I think this is eligible for #urgency bonus.

• Assign date: Aug 22
• C+ approved and requested engineer review: Aug 24
• Merged without change requests: Aug 26

[flaviadefaria]

@situchan @s-alves10 offers sent to both of you.

[flaviadefaria]

That's fair @situchan I'll add the 50% bonus once you've both accepted the contract.

New Payment Summary:

@situchan requires payment = $1000 + $500 (bonus) = $1500
@s-alves10 requires payment = $1000 + $500 (bonus) = $1500
@parasharrajat does not require payment (Eligible for Manual Requests) = $250 (reporting bonus)

[flaviadefaria]

@situchan I'm waiting for you to accept the offer
@s-alves10 has been paid

[flaviadefaria]

Everyone has been paid.

[parasharrajat]

Payment requested as per #21346 (comment)

[flaviadefaria]

Oh sorry that I closed this before you were paid @parasharrajat! I'll reopen and switch this to weekly.

[parasharrajat]

@flaviadefaria It is fine, I can track both ways(open or closed).

[JmillsExpensify]

$250 payment for @parasharrajat approved based on BZ summary.

[youssef-lr]

Are we good to close this out?

[flaviadefaria]

Alright seems like we're all done here - closing it!