-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android - Conversation without messages is still displayed after navigating away #2121
Comments
Triggered auto assignment to @johncschuster ( |
Triggered auto assignment to @joelbettner ( |
I think this has what it needs to be worked on by an engineer. Un-assigning myself for triage. |
@joelbettner "I think this has what it needs to be worked on by an engineer. Un-assigning myself for triage." |
Double checking with Joel before posting |
@mallenexpensify yes, external contributor or Expensify engineer. Either should be fine. |
@johncschuster tossing back to you since you were the original auto-assigned triager, can you post to Upwork plz. |
Strike that, I should add the External label to get someone from the CM team assigned, NOT a triager. Sorry @johncschuster |
Triggered auto assignment to @kevinksullivan ( |
It seems like correct behavior. Actually, that chat is currently active(which means if you slide right you would see that report)so it is visible in LHN. if you switch to another chat then it would be removed from LHN. @shawnborton But it does trigger one question, Do we need to highlight the active chat in some way on LHN in mobile devices? |
Issue reproducible during today's KI retests |
1 similar comment
Issue reproducible during today's KI retests |
Issue reproducible during today's KI retests |
Issue reproducible today during KI retests |
2 similar comments
Issue reproducible today during KI retests |
Issue reproducible today during KI retests |
Sorry I missed this one. I also think it is ok for the conversation to remain if it disappears once no longer "active". That said I think consistency across platforms is important here. @isagoico does iOS immediately disappear? |
Issue reproducible today during KI retests. |
Yes, iOS has the same behaviour. So when I reproduced the issue I think this may be the expected behaviour. The conversation does disappear when you navigate to another conversation. On mobile it looks like you're navigating away but you need to navigate to another conversation to "close" the other one. |
Got it. I think we'll close this one out for now then. Feel free to reopen if I am missing anything! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Expected Result:
When navigating away, the conversation should not be displayed in the LHN if it doesn't have any messages.
Actual Result:
When navigating away from the conversation it is still displayed in the chat list
Action Performed:
Workaround:
Unknown
Platform:
Where is this issue confirmed?
Web
iOS
Android ✔️
Desktop App
Mobile Web
Version Number: 1.0.7-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Unable to check if the issue is reproducible in the production app.
I Checked the behaviour in Web and the conversation does disappear when navigating away
Whatsapp.Video.2021-03-26.At.8.36.53.Pm-1.mp4
Expensify/Expensify Issue URL:
The text was updated successfully, but these errors were encountered: