[HOLD for payment 2023-06-28] [Hold] Hovering on avatar and hovering on display name shows different pictures

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. On staging > Create a group with multiple users that has a default avatar and with a display picture set
2. Click on details of the group chat to open the list of users
3. Hover on circular frame present at the beginning and then hover over the email or the name of the user
4. Result: Hovering on the display name or the email of the user shows avatar for the user that has profile picture set (works well if you click on the avatar )

Expected Result:

Hovering on avatar and hovering on display name should same pictures

Actual Result:

Hovering on avatar and hovering on display name shows different pictures

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-06-13_20.26.19.mp4

Recording.971.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686630542117569

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[avi-shek-jha]

Additional point to reproduce the bug easily: Please create a group with a user that has a profile picture( as given in the last line of step 1.)

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hovering on avatar and hovering on display name shows different pictures

What is the root cause of that problem?

App/src/components/DisplayNames/index.js

Lines 90 to 94 in 93957f0

	: _.map(this.props.displayNamesWithTooltips, ({displayName, accountID, avatar, login}, index) => (
	<Fragment key={index}>
	<UserDetailsTooltip
	key={index}
	accountID={accountID}

accountID doesn't exist for some participants

What changes do you think we should make in order to solve the problem?

get accountID from login in ReportUtils. This approach is already used in all other pages

accountID={ReportUtils.getAccountIDForLogin(login)}

[bondydaa]

hmm this seems like someone broke something in the API and we're not returning the some data anymore.

I don't know that we should add another call to fetch the data again like suggested by in the proposal since in theory we should already have this data.

[bondydaa]

PR is up here #20727

[mountiny]

I think this is minor edge case and we should be alright with not CPing this imho.

[bondydaa]

@mountiny so not a blocker then? can't be a blocker and not get CP'd.

[bondydaa]

okay this is not a blocker then #20727 (comment)

and will be fixed with #20473.

I'm removing the labels and throwing a hold on this and we can retest once #20473

[bondydaa]

actually i copied the steps from here on to that PR so we should make sure we get it tested

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Main personalDetailsList & policyMembers Onyx key migrations #20473

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@bondydaa] The PR that introduced the bug has been identified. Link to the PR:
• [@bondydaa] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@bondydaa] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@bondydaa] Determine if we should create a regression test for this bug.
• [@bondydaa] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

I think this was found due to a regression from a previous issue.
Issue Reporting Payment would go to @avi-shek-jha [$250]

The fix was done via another GH and assignees.

[abekkala]

@avi-shek-jha payment offer was sent!

[avi-shek-jha]

Accepted. Thanks.

[abekkala]

@avi-shek-jha payment sent and contract ended - thank you! 🎉