[HOLD for payment 2023-07-06] [$1000] iOS - Thread - LHN is cut if swipe away from thread and chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #19185

Action Performed:

1. Open iOS app on a real device
2. Open a chat
3. Long press a message in chat that doesn't have a thread
4. Tap "Reply in thread"
5. Swipe thread screen to the right to close it and land in chat
6. Swipe chat screen to the right to close it and land in LHN
7. Repeat steps 2-6 if you cannot initially reproduce

Expected Result:

LHN is displayed screen-wide without any issues

Actual Result:

There is an empty space at the bottom of the LHN after swiping from the thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.26.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6086634_IMG_7883.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01558dcf5b3e274d73
• Upwork Job ID: 1668283079090876416
• Last Price Increase: 2023-06-12

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[amyevans]

• I'm able to reproduce both when swiping back and using the back button, on my physical iPhone on version 1.3.26.0
• I'm unable to reproduce this on a simulator on main
• I'm unable to build locally to my physical iPhone to further test/debug:

error:Failed to prepare the device for development. This operation can fail if the version of the OS on the device is incompatible with the installed version of Xcode. You may also need to restart your Mac and device in order to correctly detect compatibility.

As next steps I'll try to resolve that Xcode error and also take a look through the PRs on staging to see if something sticks out.

cc @mountiny in case you have any initial thoughts. It feels like it could still be related to the navigation refactor, though I'm not positive.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[situchan]

Navigation refactor is already on production so should not be related.

[amyevans]

I got my local build issues sorted 🎉 , will continue to look for the PR causing the issue

[amyevans]

Ok I feel like I'm going a little bit insane with this one (in that I'll test against a commit once and not be able to repro the bug, then test again later and it's reproducible, so I start to question if I can trust my testing or if I need to "start over", or what exactly is going on).

But I decided to take a step back and install the production app and retest there, and I am able to reproduce the bug:

20514-repro.mov

So I think at the least this isn't a Deploy Blocker (cc @roryabraham curious if you agree). It doesn't happen the first time doing the action, but on any subsequent repeats of the action it does. Video 2 after a fresh sign in:

20514-repro-2.mov

[amyevans]

I also confirmed on main that it doesn't happen on the first time swiping but does on subsequent, so that is consistent with production. I'm going to go ahead and remove the DeployBlockerCash label.

@mountiny / @WoLewicki, on Monday would y'all mind taking a look at this one to determine if it's indeed related to the navigation refactor? 🙇‍♀️

[amyevans]

Going to a get a BZ member assigned here as well as open it up for external help.

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01558dcf5b3e274d73

[melvin-bot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[fedirjh]

@mountiny @amyevans This issue is reproducible on latest main on simulator as well

Screen.Recording.2023-06-16.at.12.11.16.PM.mov

[mountiny]

@fedirjh nice did you try on the branch?

[fedirjh]

@mountiny Yes, I have tested both the branch and the iOS build, and it appears to be working fine on both the simulator and a real device.

[mountiny]

I see you commented there, thanks! We might have ti investigate a different solution which wont disable the react-freeze to prevent any performance regressions.

[melvin-bot]

📣 @adamgrzybowski You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Assigning Adam as he has worked on the original refactor hence his task now is to fix all the follow up bugs and he got around to this one. Hence no proposal in this case from them.

[adamgrzybowski]

Video of the newly found related problem and reproduction steps:

1. Open the first chat
2. Deeplink to another chat
3. Deeplink again to chat that is not currently opened
4. Select the input field
5. Swipe back
6. Swipe back again

ios.mov

Currently looking for a solution for this

[adamgrzybowski]

Hey, update on this issue. Here is PR to fix that. I just updated this PR so the patch for react-native matches the changes that are proposed here to fix this upstream.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @adamgrzybowski got assigned: 2023-06-20 14:59:49 Z
• when the PR got merged: 2023-06-27 19:53:19 UTC
• days elapsed: 5

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [navigation-refactor ] Disable KeyboardAvoidingView for the BaseSidebarScreen and fix KeyboardAvoidingView used with react-freeze #21124

If no regressions arise, payment will be issued on 2023-07-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

@slafortune Only payment here is to @fedirjh and thats $1000 for reviewing and testing the PR.

Thanks for working on this. I have created Monthly issue as a reminder for us to remove the patch once we get the fix in the RN release #22155 We can close this after the payment

[slafortune]

@fedirjh offer sent!

[slafortune]

Paid!