[HOLD for payment 2023-06-29] [$1000] iOS - Copy and Download buttons overlap with Next button when app is in Spanish

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Sign in and enter the app
2. Change language to Spanish
3. Go to Seguridad -> Autenticación de dos factores

Expected Result:

Button should not overlap between each other

Actual Result:

Copy and Download buttons overlap with Next button when app is in Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.23.6

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6079407_IMG_1318.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bb40af209228ca22
• Upwork Job ID: 1666201965044396032
• Last Price Increase: 2023-06-06

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Copy and Download buttons overlap with Next button when app is in Spanish

What is the root cause of that problem?

We are wrapping both FixFooter and Content inside ScrollView, and when we change language to Spanish, the text will has more lines, it makes the content of the CodeSection overlap the FixedFooter because it has position fix

What changes do you think we should make in order to solve the problem?

We should only wrap the content with ScrollView not the FixFooter.
Also change the ScrollView contentContainerStyle={styles.flex1} to style={styles.flex1}, and add the styles.flexGrow0 to the FixedFooter to make sure our content can scroll above the FixedFooter.

            <FullPageOfflineBlockingView>
                <ScrollView style={styles.flex1}>
                    <Section
                        title={props.translate('twoFactorAuth.keepCodesSafe')}
                        icon={Illustrations.ShieldYellow}
                        containerStyles={[styles.twoFactorAuthSection]}
                        iconContainerStyles={[styles.ml6]}
                    >
                    </Section>
                </ScrollView>
                <FixedFooter style={[styles.twoFactorAuthFooter, styles.flexGrow0]}>
                    <Button
                        success
                        text={props.translate('common.next')}
                        onPress={() => Navigation.navigate(ROUTES.SETTINGS_2FA_VERIFY)}
                        isDisabled={isNextButtonDisabled}
                    />
                </FixedFooter>
            </FullPageOfflineBlockingView>

What alternative solutions did you explore? (Optional)

N/A

Result

Screen.Recording.2023-06-04.at.08.07.34.mov

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[faizansahib]

hello

[melvin-bot]

📣 @faizansahib! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[faizansahib]

email:[email protected] upwork Profile Link : https://www.upwork.com/freelancers/faizans50

[twisterdotcom]

Weird. Yes, I can repro.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bb40af209228ca22

[melvin-bot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Triggered auto assignment to @arosiclair (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[benjaminbennet]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Copy and Download buttons overlap with Next button when app is in Spanish

What is the root cause of that problem?

FixedFooter and Section are wrapped inside scrollview, when content is overflowed it made the content overflow the bottom section.

What changes do you think we should make in order to solve the problem?

We should reduce the padding, margin between component to prevent it overflow. IMO, the current margin and padding inside CodePage are so big.

What alternative solutions did you explore? (Optional)

N/A

[hungvu193]

I think your solution is like a hack, because with smaller screen this issue can still happen @benjaminbennet

[Santhosh-Sellavel]

@Expensify/design Do we need to fix anything here?

[shawnborton]

Hmm I don't understand why the buttons/background card area overlap the button like that, but it's definitely a bug. @MonilBhavsar can you take a look at this one since I think you worked on this feature?

[Santhosh-Sellavel]

@kbecciv On what device did the issue occurred?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: CodesPage buttons overlapping #20575

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[twisterdotcom]

Hi @greg-schroeder - sorry to leave this with you. I'm OOO and we just need to handle payment today and a test case.

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: fix: 2FA bug fixes #19260
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: 2FA bug fixes #19260 (comment)
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This should have been caught in this review based on the checklist
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

We don't need a separate regression test here, this is minor Ui polish. Existing cases should be enough. @arosiclair Let me know if you differ on any of the above.

Thanks!

Cc: @twisterdotcom

[greg-schroeder]

No problem @twisterdotcom - I'll take care of payment once we reach the payment date tomorrow :)

[greg-schroeder]

Wait actually I'm coming into this a bit late as I didn't managed this issue from the start - are we paying full price for this (but just to C+ for review)? There was some kind of regression here but I'm not certain @arosiclair @Santhosh-Sellavel

[Santhosh-Sellavel]

@greg-schroeder Better this discussion can happen on Slack or new dot. We can wait for @twisterdotcom, I'm in no rush to collect payments here.

[greg-schroeder]

Good call, I will open a discussion

[greg-schroeder]

I sent you an offer @Santhosh-Sellavel for this one... given you're a different reviewer than the initial PR let's just go with the standard payment.

[greg-schroeder]

awaiting payment acceptance and we can close this out

[melvin-bot]

@arosiclair, @twisterdotcom, @thiagobrez, @greg-schroeder, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Santhosh-Sellavel]

Not overdue

[greg-schroeder]

Did you want to accept payment for this @Santhosh-Sellavel?

[greg-schroeder]

Closing for now as everything else is complete. :)

[anmurali]

Paid Santhosh on new Dot.