[HOLD for payment 2023-08-08] [$1000] Invite message with apostrophe is converted to uni code in invite SMS

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open workspaces
4. Open any workspace
5. Open manage members
6. Click on invite
7. Select your contact number user (user which has contact number as primary contact and that number is available with you to receive text msg) and continue
8. Write any invite message with apostrophe eg: This is test's message
9. Click on invite
10. On your device which has that contact number, observe the message received

Expected Result:

App should not convert apostrophe into uni code in invite SMS

Actual Result:

App converts apostrophe into uni code in invite SMS

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

invite.SMS.issue.mobile.mp4

message.with.apostrophe.is.converted.in.msg.send.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684770159646489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016156d7f5010b1279
• Upwork Job ID: 1666392553307992064
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[therealsujitk]

The welcome message escaped for HTML emails - #16552, I guess it doesn't make sense to escape SMS messages. To resolve this the message will have to be unescaped internally before sending the SMS, or revert the PR and escape for emails internally.

[maddylewis]

i can repro this:

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[maddylewis]

@cristipaval - just confirming that this is an Internal issue before adding that label - lmk!

[cristipaval]

Yes, this seems to be internal. I can fix it early next week when I am back home. I am currently having some roaming issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016156d7f5010b1279

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

[cristipaval]

I investigated this a bit and it seems that it could be made external. The App sends #x27; instead of the single quote.

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @0xmiroslav is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @cristipaval is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: do not escape HTML special chars for an invite's welcomeNote #21912

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment
• @0xmiroslav requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cristipaval]

@0xmiroslav can you please take care of the checklist from above?

[cristipaval]

Waiting for @0xmiroslav

[0xmiros]

No PR caused regression. This case was missed during initial implementation of welcomeNote.

Regression Test Proposal

1. Go to Settings > Workspaces > any Workspace > Members > Invite
2. Select 2 users - one with email, another with phone number as logins
3. Update message to "This is test's message"
4. Click on Invite
5. Verify that the text message received by email and SMS contains the actual apostrophes in the invite message, and not escaped HTML sequences.

[maddylewis]

apologies! i issued a couple of payments early:

• @dhanashree-sawant should be paid for the reporting bonus - paid early
• @akinwale for the solution - paid early
• @0xmiroslav as C+ - waiting for Miroslav to accept the offer in Upwork and then i will process that payment

[0xmiros]

I am still discussing with team on email regarding my payment.

[maddylewis]

@0xmiroslav - should i hire Volodomyr to this issue?

[0xmiros]

@0xmiroslav - should i hire Volodomyr to this issue?

yes please. Hope you already have all info from email

[maddylewis]

okay, here is the updated job post - https://www.upwork.com/jobs/~0163e9e66ca38f82a1

im still a little unclear how to correctly send the payment to you. i will ask internally and then follow up.

[melvin-bot]

@akinwale, @cristipaval, @maddylewis, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@akinwale, @cristipaval, @maddylewis, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[maddylewis]

i just need to pay @0xmiroslav and then i can close this out. i confirmed how to do that on Friday so doing now!

[maddylewis]

sent offer to Volodymyr

[maddylewis]

everyone is paid! #20081 (comment)