[HOLD for payment 2023-05-29] [HOLD for payment 2023-05-25] Prevent creating new requests from within a settled expense report

[Julesssss]

@trjExpensify @JmillsExpensify @luacmartins @mountiny

Problem

Currently, the requester can continue to create requests from within a settled expense report. This is not possible for the payee after refreshing the page.

Expected

Current

Solution

Blocks users from:

• requesting money from within a settled IOUReport or expense report
• or sending money from an iouReport in any state
• sending money from expense report in any state
• requesting or sending money from transaction thread

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01be7b10bebf499be1
• Upwork Job ID: 1658503343790088192
• Last Price Increase: 2023-05-16

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01be7b10bebf499be1

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

[rushatgabhane]

Holding on #18604

[trjExpensify]

Nice, I agree you shouldn't be able to request money within a settled report. You shouldn't be able to Send money within any expense/iouReport.

@thienlnam, should you be able to Assign tasks within an expense/iouReport? Seems like that might break. Outside of the scope of this PR though!

[thienlnam]

@thienlnam, should you be able to Assign tasks within an expense/iouReport? Seems like that might break. Outside of the scope of this PR though!

Actually, you should be able to assign tasks anywhere - I'm not sure if it works out of the box right now because that hasn't been our focus for V1 - but technically yes should be possible!

[trjExpensify]

Yeah, is that going to break though? In which case, do we want to not show the Assign Task option until we firm up on how it's possible to add a task to an expense/iouReport?

[thienlnam]

It actually does work out of the box - there is a bug with the avatar in the LHN but we can fix that along with the the avatars for requests

[trjExpensify]

Cool. I think avatars for requests is being fixed if you look at the latest we're working on from here: https://expensify.slack.com/archives/C03TQ48KC/p1684276084051879?thread_ts=1684266162.911009&cid=C03TQ48KC

[luacmartins]

No longer on hold

[mountiny]

Taking this over also updated the solution with more cases we will block

[melvin-bot]

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[mountiny]

PR merged, @rushatgabhane $1000 flat rate for the PR help

[rushatgabhane]

dropping a note for Tom to hire account "Satish Gabhane" - https://www.upwork.com/freelancers/~01212e8255b02ae924

context - https://expensify.slack.com/archives/C02NK2DQWUX/p1683614947522329

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent additional requests on settled request reports #19033

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.16-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent additional requests on settled request reports #19033

If no regressions arise, payment will be issued on 2023-05-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[trjExpensify]

Errr.. why are there two payment dates on this issue? 😕

[Julesssss]

I've seen this on quite a few issues over the last 2 weeks.

[trjExpensify]

So are we waiting on the 29th or is this due today?

[trjExpensify]

In the meantime, offer sent to Satish on this job in prep @rushatgabhane 👍

[trjExpensify]

PR hit prod 7 days ago. Paid and closing.

[Julesssss]

So are we waiting on the 29th or is this due today?

Yeah, the date was over a week ago.