[HOLD for payment 2023-08-02] [HOLD for payment 2023-05-29] [$1000] Normal cursor is displayed in some parts of compose box and on double click in that cursor, app doesn't focus on compose box but selects placeholder 'Write something...' text

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Lose focus from compose box
4. Hover over compose box and observe that few area above and below 'Write something...' text displays normal pointer
5. Double click when normal pointer is visible and observe

Expected Result:

App should display edit pointer on the whole compose box and on double click, it shouldn't select placeholder text

Actual Result:

App displays normal pointer on some parts of compose box when not in focus and on double click, it selects placeholder text

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.398.mp4

normal.pointer.on.compose.box.and.select.on.placeholder.on.double.click.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682594448594829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f860adb042d7b50e
• Upwork Job ID: 1655965727105691648
• Last Price Increase: 2023-05-16

[MelvinBot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[miljakljajic]

I've been rolling out the monthly leaderboard so I haven't been able to get to this yet.

[melvin-bot]

@miljakljajic Huh... This is 4 days overdue. Who can take care of this?

[miljakljajic]

Got the go ahead to work on this: https://expensify.slack.com/archives/C01SKUP7QR0/p1683645493591139

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f860adb042d7b50e

[melvin-bot]

Current assignee @miljakljajic is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @tgolen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Normal cursor is displayed in some parts of compose box and on double click in that cursor, app doesn't focus on compose box but selects placeholder 'Write something...' text

What is the root cause of that problem?

As you can see input itself is not covering all of the composer area. Thus, when we click on wrapper it won't focus composer

What changes do you think we should make in order to solve the problem?

We should turn style outer wrapper to have cursor: text. Also we should turn View element into Pressable and when it is pressed we should focus composer if not focused

App/src/pages/home/report/ReportActionCompose.js

Line 883 in 9b5397e

<View style={[styles.textInputComposeSpacing, styles.textInputComposeBorder]}>

We should also, add

  onMouseDown={e => e.preventDefault()}

to prevent losing focus when outside of input element is pressed

What alternative solutions did you explore? (Optional)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

1. App displays normal pointer on some parts of compose box when not in focus

2. On double click, it selects placeholder text

What is the root cause of that problem?

1. The textarea is not covering the full height of the input
   There's the paddingVertical: 5 here https://github.com/Expensify/App/blob/802e406cc8a7f8d5677061a13b2a5b4076f0bae5/src/styles/styles.js#LL1557C28-L1557C28 of the textarea container
   And also when the textarea is 1 line, its height is only 20px while the height of the container is 38px (40px minHeight minus 2px border)
   So when we click anywhere outside that 20px, it will show normal cursor since we're not hovering over the textarea but the container instead

2. The placeholder text of textarea is currently selectable, while placeholder of input is not as per this logic

   App/web/index.html

   Line 43 in 802e406

   input::placeholder {

This can be reproduced not only as in the OP, but if we double click a bit below the composer container itself, we can select the placeholder text.

What changes do you think we should make in order to solve the problem?

1. We need to make the textarea capture the full height of the container.

• Remove the paddingVertical: 5 in https://github.com/Expensify/App/blob/802e406cc8a7f8d5677061a13b2a5b4076f0bae5/src/styles/styles.js#LL1557C28-L1557C28, and add { paddingTop: 5, paddingBottom: 5 } to the composer style in

  App/src/styles/styles.js

  Line 1537 in 802e406

  paddingTop: 0,

  (I've tested and it doesn't cause the regression mentioned in

  App/src/styles/styles.js

  Line 1534 in 802e406

  // paddingVertical: 0, alignSelf: 'center', and textAlignVertical: 'center'

  , perhaps there was some updates in React Native that fixes it so it should be safe to set the paddingTop and paddingBottom now)
• When numberOfLine of the Composer is 1, the padding vertical should be { paddingTop: 9, paddingBottom: 9 } so that the textarea will capture the full min height of the container (38px), and the input is centered correctly. For multiple lines it should be { paddingTop: 5, paddingBottom: 5 } as mentioned above.

2. We need to add , textarea::placeholder to

   App/web/index.html

   Line 43 in 802e406

   input::placeholder {

   so that the disabling of placeholder text select is applied to textarea as well.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@tgolen @mananjadhav @miljakljajic this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[miljakljajic]

Still reviewing proposals. @mananjadhav do you have any initial thoughts on these two entries?

[miljakljajic]

Going to assign another BZ team member for while I'm at ExpensiCon 3 and then OOO for a week after.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[isabelastisser]

Reviewing this, the payment is due, but the issue caused a regression, so a penalty will be applied.

Each regression reduces the payment amount for C+ by 50%. Additionally, no efficiency bonus is paid for merging quickly if there are any regressions.

C+ @mananjadhav
Reported by: @dhanashree-sawant
Assigned contributor: @dukenv0307, assigned on May 22.

PR was merged on May 22.

• I will process the payments in Upwork now. @mananjadhav, please complete the checklist so that I can close the issue. Thanks!

[isabelastisser]

@dukenv0307 what's your Upwork name/profile? I can't find you there. Please apply for the job below and I will process the payment. Thanks!

Upwork: https://www.upwork.com/jobs/~01f860adb042d7b50e

[mananjadhav]

@isabelastisser The payment should've been pending for this one. The linked PR fixing the regression is still open.

About the checklist, I couldn't trace the PR for this change. I can see the textInputComposeSpacing exists a long time.

[dukenv0307]

@isabelastisser I've already applied, my profile is https://www.upwork.com/freelancers/~01f5cbe690701118a2
Thank you!

[isabelastisser]

@arielgreen @tgolen I'm not sure how to follow up on @mananjadhav comment below, can you please help? Thanks!

About the checklist, I couldn't trace the PR for this change. I can see the textInputComposeSpacing exists a long time.

[isabelastisser]

@arielgreen unassigning myself based on this new process (SO here), and assigning you again since you were the original assignee; I'm going OOO.

[miljakljajic]

I've tagged @mananjadhav in the C+ room to discuss.

[miljakljajic]

@dukenv0307 please accept the contract and we'll get you paid!

[dukenv0307]

@miljakljajic accepted, thank you!

[miljakljajic]

All agents have been paid, contracts ended - closing

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @dukenv0307 got assigned: 2023-05-23 01:01:46 Z
• when the PR got merged: 2023-07-24 15:00:45 UTC
• days elapsed: 44

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/regression 18110 composer should have the same height in other platforms #19516

If no regressions arise, payment will be issued on 2023-08-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligable for Manual Requests)
• @dukenv0307 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: