Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-05-25] ReopenTask Front-End #17469

Closed
thienlnam opened this issue Apr 14, 2023 · 15 comments
Closed

[HOLD for payment 2023-05-25] ReopenTask Front-End #17469

thienlnam opened this issue Apr 14, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@thienlnam
Copy link
Contributor

thienlnam commented Apr 14, 2023

https://docs.google.com/document/d/1uFj0Oh9qtFJ-EH-lg00oMflo8uhkV2yXUT8Tbg6cKws/edit#bookmark=id.defzvb9j9kqq

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015929b73027eab42d
  • Upwork Job ID: 1662130072732762112
  • Last Price Increase: 2023-05-26
@thienlnam thienlnam self-assigned this Apr 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2023
@thienlnam thienlnam changed the title ReopenTask Front-End [HOLD 16855] ReopenTask Front-End Apr 26, 2023
@thienlnam
Copy link
Contributor Author

Held on CreateTask #16855 and also the corresponding Auth command

@melvin-bot melvin-bot bot removed the Overdue label Apr 26, 2023
@thienlnam
Copy link
Contributor Author

This is still holding on the ReopenTask auth command https://github.com/Expensify/Expensify/issues/274091, but the front-end can be worked on in conjunction with the auth PR going out

To trigger a task report view, just force isTaskReport to return true and click on any chat report

@thienlnam thienlnam removed their assignment May 3, 2023
@MariaHCD MariaHCD self-assigned this May 4, 2023
@MariaHCD
Copy link
Contributor

MariaHCD commented May 15, 2023

Working on the Auth PR so this can be unblocked

@thienlnam thienlnam changed the title [HOLD 16855] ReopenTask Front-End ReopenTask Front-End May 15, 2023
@thienlnam thienlnam mentioned this issue May 15, 2023
57 tasks
@thienlnam thienlnam self-assigned this May 15, 2023
@thienlnam
Copy link
Contributor Author

Pushing this forward while Maria is offline

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 15, 2023
@melvin-bot melvin-bot bot changed the title ReopenTask Front-End [HOLD for payment 2023-05-25] ReopenTask Front-End May 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 24, 2023
@MariaHCD
Copy link
Contributor

I think we're done here?

@thienlnam
Copy link
Contributor Author

Ah we'll actually need to get @fedirjh payment for internal C+ review

@thienlnam thienlnam added the NewFeature Something to build that is a new item. label May 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

@thienlnam thienlnam added the Internal Requires API changes or must be handled by Expensify staff label May 26, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

Job added to Upwork: https://www.upwork.com/jobs/~015929b73027eab42d

@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

Current assignee @fedirjh is eligible for the Internal assigner, not assigning anyone new.

@thienlnam
Copy link
Contributor Author

@tjferriss This is ready for payment!

Internal Review (C+) to @fedirjh

@tjferriss
Copy link
Contributor

@fedirjh the contract has been extended to you. Once accepted, I'll process payment.

@fedirjh
Copy link
Contributor

fedirjh commented May 29, 2023

@tjferriss Thank you, Accepted.

@tjferriss
Copy link
Contributor

@fedirjh payment has been sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants