Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar lost focus when LHN finish loading #17274

Closed
1 of 6 tasks
kavimuru opened this issue Apr 11, 2023 · 13 comments
Closed
1 of 6 tasks

Search bar lost focus when LHN finish loading #17274

kavimuru opened this issue Apr 11, 2023 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Apr 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Enable slow network (i.e. slow 3G on Chrome devtool)
  2. Open app and login to an account
  3. When the LHN is still loading, open the search bar and type anything
  4. When the LHN is loaded, notice that the search input lost focus

Expected Result:

The search input is still being focus

Actual Result:

The search input lost focus

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.98-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-04-11.at.09.43.23.mov
Recording.199.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tienifr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681181162608589

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 11, 2023
@MelvinBot
Copy link

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 11, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@sophiepintoraetz
Copy link
Contributor

Clarifying in the slack thread.

@sophiepintoraetz sophiepintoraetz added the Needs Reproduction Reproducible steps needed label Apr 13, 2023
@sophiepintoraetz
Copy link
Contributor

2023-04-13_17-53-08 (1)

Not able to reproduce - @kavimuru or @tienifr - can you review and let me know what's missing?

@tienifr
Copy link
Contributor

tienifr commented Apr 13, 2023

Screen.Recording.2023-04-13.at.15.21.59.mov

@sophiepintoraetz I still can reproduce and I think I know the RCA. If it's open I can post the proposal. Thanks

@tienifr
Copy link
Contributor

tienifr commented Apr 13, 2023

Ah, I see the problem in your video, you're opening the archived report after login. Please try other way to open the active report at first. Thanks

@tienifr
Copy link
Contributor

tienifr commented Apr 20, 2023

@sophiepintoraetz any updates?

@sophiepintoraetz
Copy link
Contributor

@tienifr - please refrain from a daily bump - I have let you know I will review it when I have a moment. Given this is a low priority bug, I don't think it warrants an immediate fix.

@sophiepintoraetz sophiepintoraetz added Weekly KSv2 and removed Daily KSv2 labels Apr 20, 2023
@tienifr

This comment was marked as off-topic.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 24, 2023
@MelvinBot
Copy link

@sophiepintoraetz this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@sophiepintoraetz
Copy link
Contributor

@tienifr - please do not bypass the process - when this label has been assigned external, then you are able to contribute this. I'm sure you are well aware of the contributor rules - so I have marked your comment as off-topic.

@sophiepintoraetz sophiepintoraetz added Weekly KSv2 and removed Daily KSv2 labels Apr 26, 2023
@tienifr
Copy link
Contributor

tienifr commented Apr 26, 2023

@sophiepintoraetz

You can propose solutions on any issue at at any time, but if you propose solutions to jobs before the Help Wanted label is applied, you do so at your own risk. Proposals will not be reviewed until the label is added and there is always a chance that we might not add the label or hire an external contributor for the job.

I think we have the new contributor rules: https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md

I also updated my proposal header: Proposal -> Posting proposal early as per the new contributing guidelines for more clarity. Thanks

@sophiepintoraetz
Copy link
Contributor

sophiepintoraetz commented Apr 27, 2023

Thank you for the redirect - that is new! In any case - I am going to close this issue for now, as I see we have a larger issue around focus and what we want to do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants