Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-01] [Group 1][Accessible Pressables] Migrate GrowlNotification #17006

Closed
roryabraham opened this issue Apr 6, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023

HOLD on #16988

Description

Migrate the GrowlNotification component to use PressableWithoutFeedback.

@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham changed the title [HOLD][Accessible Pressables] Migrate GrowlNotification [HOLD][Priority 1][Accessible Pressables] Migrate GrowlNotification Apr 6, 2023
@roryabraham roryabraham changed the title [HOLD][Priority 1][Accessible Pressables] Migrate GrowlNotification [HOLD][Group 1][Accessible Pressables] Migrate GrowlNotification Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 1][Accessible Pressables] Migrate GrowlNotification [Group 1][Accessible Pressables] Migrate GrowlNotification May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@robertKozik
Copy link
Contributor

Hey, could you assign me to this? I started working on it, but PR is not ready yet

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels May 15, 2023
@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables May 16, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels May 25, 2023
@melvin-bot melvin-bot bot changed the title [Group 1][Accessible Pressables] Migrate GrowlNotification [HOLD for payment 2023-06-01] [Group 1][Accessible Pressables] Migrate GrowlNotification May 25, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot removed the Weekly KSv2 label May 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

@robertKozik Huh... This is 4 days overdue. Who can take care of this?

@0xmiros
Copy link
Contributor

0xmiros commented Jun 5, 2023

@roryabraham can you please assign BZ member for me?

@roryabraham roryabraham added the Bug Something is broken. Auto assigns a BugZero manager. label Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@roryabraham roryabraham added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. Bug Something is broken. Auto assigns a BugZero manager. labels Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Current assignee @sophiepintoraetz is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 Overdue labels Jun 6, 2023
@roryabraham
Copy link
Contributor Author

Hi @sophiepintoraetz, all that's needed here is a C+ payment for @0xmiroslav

@roryabraham roryabraham self-assigned this Jun 6, 2023
@sophiepintoraetz
Copy link
Contributor

/@roryabraham - how much is being paid here?

@0xmiros
Copy link
Contributor

0xmiros commented Jun 6, 2023

This can be considered internal review so flatten 1k

@sophiepintoraetz
Copy link
Contributor

All right - offer is out to you @0xmiroslav!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessible Pressables Jun 7, 2023
@roryabraham
Copy link
Contributor Author

It's fine in this case, but just to set the expectation – the remainder of the Accessible Pressable PR reviews should use the rate of $250 for the PR reviews, because they're generally pretty quick and easy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants