Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD on #17824] [$1000] mWeb - Split/Send/Request - Conversation chat is visible when split/request/send money for small phones #16965

Closed
1 of 6 tasks
kbecciv opened this issue Apr 5, 2023 · 36 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 5, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with any account
  3. Tap on Fub menu
  4. Select Split/Send/ Request option.

Expected Result:

Conversation chat is not visible when split/request/send money for small phones

Actual Result:

Conversation chat is visible when split/request/send money for small phones

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.95.0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6006922_RPReplay_Final1680699484.mp4

Expensify/Expensify Issue URL:

Issue reported by: 0xmiroslav

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d36ec9ce5a860ff8
  • Upwork Job ID: 1653851947980849152
  • Last Price Increase: 2023-05-03
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 5, 2023
@MelvinBot
Copy link

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kbecciv
Copy link
Author

kbecciv commented Apr 5, 2023

Issue was reproduced for IPhone 8

@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@garrettmknight garrettmknight added the Needs Reproduction Reproducible steps needed label Apr 10, 2023
@garrettmknight
Copy link
Contributor

Couldn't reproduce, reopen if it's still happening for you.
Uploading Screenshot 2023-04-10 at 11.29.22 AM.png…

@kbecciv
Copy link
Author

kbecciv commented Apr 10, 2023

Hello @garrettmknight! The video is not updated on your end.
Just mentioned in the title that the issue occurred in small devices, for example, iPhone 8.

@kbecciv kbecciv reopened this Apr 10, 2023
@garrettmknight
Copy link
Contributor

garrettmknight commented Apr 12, 2023

Ah, I tested on browserstack with an iPhone. 8, let me grab the screenshot:
Screenshot 2023-04-12 at 5 44 01 PM
Screenshot 2023-04-12 at 5 44 26 PM

If you're still experiencing the problem on a real device, please reopen.

@kavimuru
Copy link

kavimuru commented May 1, 2023

@garrettmknight This is still reproducible. To reproduce this issue, iOS NewDot app should be installed in the device.

@kavimuru kavimuru reopened this May 1, 2023
@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@garrettmknight
Copy link
Contributor

Ah, thanks for highlighting that step. Opening it up!

@melvin-bot melvin-bot bot removed the Overdue label May 3, 2023
@garrettmknight garrettmknight added External Added to denote the issue can be worked on by a contributor Overdue and removed Needs Reproduction Reproducible steps needed labels May 3, 2023
@melvin-bot melvin-bot bot changed the title mWeb - Split/Send/Request - Conversation chat is visible when split/request/send money for small phones [$1000] mWeb - Split/Send/Request - Conversation chat is visible when split/request/send money for small phones May 3, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01d36ec9ce5a860ff8

@MelvinBot
Copy link

Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 3, 2023
@garrettmknight garrettmknight added the Bug Something is broken. Auto assigns a BugZero manager. label May 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2023

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@garrettmknight
Copy link
Contributor

Reassigning since I'm headed OOO. @tjferriss can you keep an eye on #17824 and retest this once that's fixed? Thanks!

@garrettmknight garrettmknight added Weekly KSv2 and removed Daily KSv2 labels May 11, 2023
@garrettmknight
Copy link
Contributor

Dropping to weekly since the other issue hasn't been closed yet.

@tjferriss
Copy link
Contributor

tjferriss commented May 17, 2023

We're still waiting on the linked issue #17824

@melvin-bot melvin-bot bot added the Overdue label May 25, 2023
@madmax330
Copy link
Contributor

Still on the above

@melvin-bot melvin-bot bot removed the Overdue label May 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@madmax330
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2023
@tjferriss
Copy link
Contributor

@madmax330 @sobitneupane it looks like the PR we were on hold for has been merged with no regressions #19682. Are we good to take this off hold?

@melvin-bot melvin-bot bot removed the Overdue label Jun 14, 2023
@sobitneupane
Copy link
Contributor

@tjferriss the issue is not reproducible on my device.

@tjferriss tjferriss added the Needs Reproduction Reproducible steps needed label Jun 19, 2023
@tjferriss
Copy link
Contributor

Agreed, I can no longer reproduce the issue.

@0xmiros
Copy link
Contributor

0xmiros commented Jun 22, 2023

@tjferriss am I eligible for reporting?

@tjferriss
Copy link
Contributor

Yes, my mistake. I've sent you an offer here: https://www.upwork.com/jobs/~01608820048aa35724

@tjferriss tjferriss reopened this Jun 23, 2023
@0xmiros
Copy link
Contributor

0xmiros commented Jun 23, 2023

Accepted, thanks!

@tjferriss
Copy link
Contributor

Paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants