Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD 15550] Settings - Workspace created and deleted while offline reappears when going back online with a different name #16776

Closed
3 of 6 tasks
kbecciv opened this issue Mar 30, 2023 · 22 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Mar 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open NewDot Android app and login
  2. Go offline
  3. Create a workspace
  4. Rename workspace
  5. Delete workspace
  6. Go online
  7. Go offline
  8. Create a workspace
  9. Rename workspace
  10. Delete workspace
  11. Go online

Expected Result:

Deleted workspace should disappear

Actual Result:

Deleted workspace is displayed, sometimes with original name before renaming. Error message appears when trying to delete it again

Workaround:

Unkown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.82.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5972393_video_60.mp4
Bug5972393_video_61.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 30, 2023
@MelvinBot
Copy link

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 30, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@isagoico isagoico changed the title Workspace - Creating and deleting workspace offline triggers it's excessive appearing Settings - Workspace created and deleted while offline reappears when going back online with a different name Mar 31, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 3, 2023
@MelvinBot
Copy link

@maddylewis Whoops! This issue is 2 days overdue. Let's get this updated quick!

@maddylewis
Copy link
Contributor

@bondydaa
Copy link
Contributor

bondydaa commented Apr 7, 2023

I think this is sort of a dupe of #16090 if this is specifically a bug about the workspace name going back to the old name after you go online.

I'm pretty sure this, #16090, and #17111 all probably have the same root cause for the workspace name not properly updating so I think we should focus on #16090 to fix that.

This and #17111 also deal with deleting the workspace though so there may be another bug in these flows as well that has to deal with deleting the workspace so if we could isolate what that is exactly from the name change not working that'd be great and then we could close this or #17111

@MelvinBot
Copy link

@maddylewis Huh... This is 4 days overdue. Who can take care of this?

1 similar comment
@MelvinBot
Copy link

@maddylewis Huh... This is 4 days overdue. Who can take care of this?

@maddylewis
Copy link
Contributor

@bondydaa - just confirming your thinking on this one.

are you saying that once #16090 is fixed/closed, i can close this one out?

or, once #16090 is live, we should move forward with fixing the bug report on this issue (#16776)?

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2023
@bondydaa
Copy link
Contributor

I guess it depends on what the desired outcome of this bug report is.

@kbecciv could you clarify maybe a bit more for this ticket what we want out of this ticket?

@MelvinBot
Copy link

@maddylewis this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@maddylewis
Copy link
Contributor

bumping @kbecciv on this comment here - #16776 (comment)

@kbecciv
Copy link
Author

kbecciv commented Apr 14, 2023

@bondydaa @maddylewis Created and deleted workspace offine should not change its status when the user is back online.

@bondydaa
Copy link
Contributor

I was just made aware of this tracking issue #12775

Which is most likely the root cause for the problem with the workspace being deleted then re-appearing so I think we can hold this issue for those changes then retest.

@maddylewis maddylewis changed the title Settings - Workspace created and deleted while offline reappears when going back online with a different name [HOLD] Settings - Workspace created and deleted while offline reappears when going back online with a different name Apr 14, 2023
@maddylewis maddylewis added Weekly KSv2 and removed Daily KSv2 labels Apr 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2023
@maddylewis
Copy link
Contributor

still holding for this one - #12775

will retest once that issue is fixed.

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2023
@melvin-bot melvin-bot bot added the Overdue label May 2, 2023
@maddylewis
Copy link
Contributor

still holding i believe - #12775

@melvin-bot melvin-bot bot removed the Overdue label May 2, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@maddylewis
Copy link
Contributor

PR on staging - #12775 (comment)

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2023
@neil-marcellini neil-marcellini changed the title [HOLD] Settings - Workspace created and deleted while offline reappears when going back online with a different name Settings - Workspace created and deleted while offline reappears when going back online with a different name May 16, 2023
@neil-marcellini
Copy link
Contributor

This is no longer on hold for the replay effect, but I think we should hold it on #15550 because it's a more simple case of this problem.

@neil-marcellini neil-marcellini changed the title Settings - Workspace created and deleted while offline reappears when going back online with a different name [HOLD 15550] Settings - Workspace created and deleted while offline reappears when going back online with a different name May 16, 2023
@melvin-bot melvin-bot bot added the Overdue label May 23, 2023
@maddylewis
Copy link
Contributor

still holding

@melvin-bot melvin-bot bot removed the Overdue label May 23, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 1, 2023
@maddylewis
Copy link
Contributor

still holding - #15550

@melvin-bot melvin-bot bot removed the Overdue label Jun 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 9, 2023
@maddylewis
Copy link
Contributor

moving to monthly while still on hold - #15550

@melvin-bot melvin-bot bot removed the Overdue label Jun 12, 2023
@maddylewis maddylewis added Monthly KSv2 Overdue and removed Weekly KSv2 labels Jun 12, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jun 12, 2023
@maddylewis
Copy link
Contributor

@maddylewis maddylewis added Daily KSv2 Weekly KSv2 and removed Monthly KSv2 Daily KSv2 labels Jun 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 29, 2023
@maddylewis
Copy link
Contributor

since this is now also on hold (#15550), im going to close this. we can reopen if this is still an issue after the underlying issues are addressed in the other issues.

@melvin-bot melvin-bot bot removed the Overdue label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants