-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD][$1000] Gap between edit message and keyboard on mWeb chrome #16718
Comments
Triggered auto assignment to @adelekennedy ( |
Bug0 Triage Checklist (Main S/O)
|
@adelekennedy Eep! 4 days overdue now. Issues have feelings too... |
@adelekennedy 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
@adelekennedy 10 days overdue. I'm getting more depressed than Marvin. |
1 similar comment
@adelekennedy 10 days overdue. I'm getting more depressed than Marvin. |
@kavimuru I'm not able to reproduce this 😬 can you give it a try and let me know if you're seeing the gap? |
I tagged @dhanashree-sawant in the slack |
Hi @adelekennedy, I am still able to recreate on latest staging. Untitled.mp4 |
@adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Job added to Upwork: https://www.upwork.com/jobs/~016ea8064e577f077b |
Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak ( |
Triggered auto assignment to @cristipaval ( |
This comment was marked as duplicate.
This comment was marked as duplicate.
@koko57 Great, thanks for taking care of this one. Hold is removed now. |
@koko57 what's the status on this one? |
@cristipaval Sorry, I didn't notice that you removed on hold! BaseInvertedFlatList is still not migrated to FlashList yet - I think we should wait for it to be migrated first. |
@cristipaval I aksed my colleague that is working on the migration - there's no ticket yet for migrating the chat list to Flashlist, but it's planned. Let's put it on HOLD once again. |
Alright, I'll do it. Do we have a tracking issue for the migration on which we held this one? |
I see. I think we're good if we held this one on #30912 |
Thank you @koko57! |
Removing the HOLD. @koko57, do you have some spare time to investigate this one again? 🙏 |
@cristipaval We were holding for some other issue, because the ticket for the main chat wasn't created back then 🙂 It was created recently, so now we need to hold on this one (#33725). But if I have some spare time I'll see what's the current status of the issue - if anything changed in the meantime |
Thanks @koko57! |
Still on hold. |
same |
coming from our updated process - I think we should close this issue based on our new standards |
Held on #30912Held on #33725
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
There should be no gap between keyboard and edit message like there isn't any gap in android app
Actual Result:
There is large gap between edit message and keyboard on mWeb chrome
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.91-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
gap.android.chrome.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680022112433229
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: