[HOLD #15992][$1000] mWeb/Chrome - Chat - Android - keyboard opens when tapping outside of the edited message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/ on Android/Chrome
2. Login with any account
3. Navigate a conversation (where there are messages)
4. Tap and hold to view the action menu
5. Tap on the Pencil icon to activate the edit message box
6. Close keyboard
7. Click outside the message
8. Keyboard reopens

Expected Result:

Nothing should happen.

Actual Result:

If you edit a message, close the keyboard and click outside
this message, the keyboard reopens.

Workaround:

Unkonown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.94.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5995109_Screen_Recording_20230328_005926_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015de52e231d8c70fe
• Upwork Job ID: 1643325645053960192
• Last Price Increase: 2023-04-11

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Christinadobrzyn]

Hey @kbecciv I can't seem to test on Android/Chrome using Browserstack but this doesn't happen on any other platforms so can you make sure this is still happening?

[MelvinBot]

@kbecciv Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

pinging in QA for some help testing these - https://expensify.slack.com/archives/C9YU7BX5M/p1680624339701339

[kbecciv]

@Christinadobrzyn Able to reproduce with latest build 1.2.94.0

Screen.Recording.20230404.193617.Chrome.mp4

[Christinadobrzyn]

Thank you @kbecciv I think this should get fixed, going to add External label.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~015de52e231d8c70fe

[MelvinBot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[MelvinBot]

Triggered auto assignment to @chiragsalian (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[redstar504]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When edit composer is focused, and you close the keyboard, tapping anywhere outside will reopen the keyboard.

What is the root cause of that problem?

The problem is that the main composer receives focus when the edit composer is blurred on web, causing the keyboard to reopen. The order of operations is as follows:

The edit composer hides the main composer when it receives focus:

App/src/pages/home/report/ReportActionItemMessageEdit.js

Line 278 in f68a199

toggleReportActionComposeView(false, this.props.isSmallScreenWidth);

When the edit composer is subsequently blurred, such as pressing another item like in this issue, it then toggles the main composer back into view:

App/src/pages/home/report/ReportActionItemMessageEdit.js

Line 292 in f68a199

openReportActionComposeViewWhenClosingMessageEdit(this.props.isSmallScreenWidth);

The main composer is then conditionally rendered:

App/src/pages/home/report/ReportFooter.js

Line 89 in 17ddaa2

{(!hideComposer && this.props.shouldShowComposeInput) && (

However the problem is that the main composer has autofocus, so when it's re-rendered due to being toggled via the edit composer, it becomes focused and re-opens the keyboard on web.

What changes do you think we should make in order to solve the problem?

The behavior of autofocus seems to be inconsistent between web and native. The purpose of autofocus on the main composer component would be to provide focus on initial render. However, on web this also has the side effect of re-focusing it when it is re-rendered. The seems to be a disparity in the functionality of autofocus.

I propose that we decide on the definitive behavior and apply it to both platforms. As a result of this issue, I suggest we go with not focusing the main composer when the edit composer is blurred. It should be re-displayed, but not re-focused.

To achieve this we have a couple options:

1. We could implement the componentDidUpdate lifecycle method of the ReportFooter class to determine if the visibility changed on the current render, and pass autofocus=false down to Composer through props. Visibility toggle happens through Onyx and the shouldShowComposeInput key is passed to ReportFooter. This is probably the more robust solution and likely the one I would recommend moving forward with.

2. Another possible solution would be to hide the main composer using another method such as display: 'none' on the outer view when hideComposer || !this.props.shouldShowComposeInput evaluates to true. That way the composer would receive focus properly when initially mounted. Changing the display style prop on web doesn't seem to invoke a re-render and therefore may be more performant.

What alternative solutions did you explore? (Optional)

[parasharrajat]

This does not seem like a bug but the expected behavior.

[redstar504]

@parasharrajat The problem seems to be that the behavior is inconsistent. On web it focuses the composer after editing a message and on native it doesn't. We should probably pick one behavior and apply it to both platforms.

[parasharrajat]

IMO, This change was made recently and I don't think we have to change it. Let's get more context for this before we move forward. And, I think there are similar issues present on GH either opened or closed state. We should check those before reviewing this one.

[fedirjh]

@parasharrajat Thank you for your feedback . I will review this issue shortly.

[chiragsalian]

yeah monthly is fine for this since its on hold

[Christinadobrzyn]

Still on hold for #15992

[Christinadobrzyn]

Still on hold for #15992

[fedirjh]

Still on hold for #15992.

[Christinadobrzyn]

this is closed - #15992 - so I'll test this tomorrow and see if we need proposals.

[Christinadobrzyn]

I think this is resolved - going to ask QA to test again - https://expensify.slack.com/archives/C9YU7BX5M/p1712049800250629

[kavimuru]

@Christinadobrzyn Bug is fixed.

Screenrecorder-2024-04-02-14-17-37-631.mp4

[Christinadobrzyn]

Yay! Thank you @kavimuru! Closing

[melvin-bot]

@chiragsalian @Christinadobrzyn Be sure to fill out the Contact List!