[HOLD for payment 2023-08-21] [$250] Migrate ThumbnailImage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/ThumbnailImage.js
  • type: React.PureComponent
  • has state values: true
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[kadiealexander]

Not overdue, close to having a PR up!

[dummy-1111]

I'd love to work on this.

[kadiealexander]

Created a draft PR to discuss with @puneetlath next week.

[marcaaron]

Taking this one off HOLD.

[kadiealexander]

I have a PR in for this, just need to do a bit of testing :)

[vdem0115]

I can work on this issue now.

[kadiealexander]

Working through some testing issues that have cropped up, I think due to the new ZT trial.

[kadiealexander]

@allroundexperts could you please check this comment?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Christinadobrzyn]

It looks like we might have a regression of this here - can you check if that's the case?

[kadiealexander]

Yeah, that's the case. cc @s77rt @MonilBhavsar

[s77rt]

@kadiealexander I have explained the cause of the regression here #24424 (comment) and we have a fix for that issue already #24466.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate ThumbnailImage.js to function component  #20892

If no regressions arise, payment will be issued on 2023-08-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[kadiealexander]

Payouts due:

Issue Reporter: n/a
Contributor: n/a
Contributor+: $125 @s77rt

Eligible for 50% #urgency bonus? No

Upwork job is here.

[s77rt]

@kadiealexander We had a regression here. Can you please update the price to $125

[kadiealexander]

Done, thanks for flagging @s77rt!

[s77rt]

@kadiealexander i have accepted the offer. Thanks!

[kadiealexander]

All paid!