[HOLD for payment 2023-09-27] [$250] Migrate PressableWithSecondaryInteraction/index.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/PressableWithSecondaryInteraction/index.js
  • type: React.Component
  • has state values: false
  • has refs: true
  • has context: false
  • lifecycle methods: componentDidMount,componentWillUnmount

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0153701f0a1ebdfe82
• Upwork Job ID: 1691869303041654784
• Last Price Increase: 2023-08-16

[s-alves10]

I'd love to work on this.

[melvin-bot]

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Still overdue 6 days?! Let's take care of this!

[melvin-bot]

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. eroding to Weekly issue.

[olexyt]

I can work on this issue.

[rayane-djouah]

Can I work on this?

[Vishrut19]

Can I work on this?

[ghost]

Dibs

[mkhutornyi]

I'd like to work on this.

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[BeeMargarida]

Hi, I'm Ana from Callstack - expert contributor group - and I would like to take a look at this issue 👋

[studentofcoding]

Proposal

Please re-state the problem that we are trying to solve in this issue

Migrate index.native.js to the function component

What changes do you think we should make in order to solve the problem?

The refactored code can be seen here @marcaaron

https://github.com/studentofcoding/Expensify-App/blob/733b4e2a3b5e29b50c0d23ef3dd52accc62adf19/src/components/PressableWithSecondaryInteraction/index.js#L1-L79

[Umesh-Bhati]

can I work on this issue?

[melvin-bot]

📣 @Umesh-Bhati! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Umesh-Bhati]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~018f1a33b14bc5e0a1

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

This issue has not been updated in over 15 days. @BeeMargarida, @isabelastisser, @marcaaron, @0xmiroslav eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[BeeMargarida]

PR updated with main, ready for merge

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: migrate PressableWithSecondaryInteraction to function component #25398

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @BeeMargarida does not require payment (Contractor)
• @0xmiroslav requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[isabelastisser]

I need clarification from the team here before I can process the payment, what's the amount that @0xmiroslav needs to be paid for the C+ review for this newfeature issue? @marcaaron

The C+ was assigned on Aug 16 but the PR was merged on Sept 16 because of a merge freeze. Do newfeature issues qualify for urgency bonus? Thanks!

[0xmiros]

This is function migration work and bounty is flatten as $250

[isabelastisser]

@0xmiroslav what's your profile in Upwork?

[0xmiros]

My payment is on hold. Please close this issue for now. I am tracking so will ping here once ready to get payment.