Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD #33434][$250] Migrate index.js to function component #16186

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 52 comments
Closed
1 task

[HOLD #33434][$250] Migrate index.js to function component #16186

marcaaron opened this issue Mar 20, 2023 · 52 comments
Assignees
@puneetlath @kadiealexander @ishpaul777
Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c18f5687e5c548bf
  • Upwork Job ID: 1759601059714211840
  • Last Price Increase: 2024-02-19
  • Automatic offers:
    • s-alves10 | Contributor | 0
    • ishpaul777 | Contributor | 0
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.js to function component [HOLD][$250] Migrate index.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@melvin-bot melvin-bot bot added the Daily KSv2 label Jun 6, 2023
@s-alves10
Copy link
Contributor

I'd love to work on this.

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

This issue has not been updated in over 14 days. eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Jun 22, 2023
@kadiealexander kadiealexander self-assigned this Jun 26, 2023
@rayane-djouah
Copy link
Contributor

Can I work on this issue?

@melvin-bot melvin-bot bot added the Overdue label Jul 9, 2023
@mkhutornyi
Copy link
Contributor

I'd like to work on this.

@kadiealexander
Copy link
Contributor

Hey team! I'm working on this one internally.

@melvin-bot melvin-bot bot removed the Overdue label Jul 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 21, 2023
@kadiealexander
Copy link
Contributor

Getting close to working on this one, just a few competing priorities to deal with first!

@melvin-bot melvin-bot bot removed the Overdue label Jul 24, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 1, 2023
@kadiealexander
Copy link
Contributor

Should have a PR in soon!

@melvin-bot melvin-bot bot removed the Overdue label Aug 2, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 19, 2024

Current assignee @Santhosh-Sellavel is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 19, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 19, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 19, 2024

📣 @s-alves10 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@ghost
Copy link

ghost commented Feb 19, 2024

Dibs

@ishpaul777
Copy link
Contributor

I can take as C+ while Santosh is unavailable

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 19, 2024

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@s-alves10 s-alves10 mentioned this issue Feb 19, 2024
Closed
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 20, 2024
@puneetlath
Copy link
Contributor

Unfortunately @s-alves10 isn't going to be able to finish this issue. I'm assigning to @mkhutornyi to take over

@puneetlath puneetlath assigned mkhutornyi and unassigned s-alves10 Mar 13, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 13, 2024

❌ There was an error making the offer to @mkhutornyi for the Contributor role. The BZ member will need to manually hire the contributor.

@mkhutornyi
Copy link
Contributor

We need to put this on hold for #33434
Reason:

  • some work here before that PR is merged will mostly get removed
  • the removing code part was already migrated into functional component / TS in upstream
  • PR is active and will be merged soon

Discussion: https://expensify.slack.com/archives/C02NK2DQWUX/p1710425733927159?thread_ts=1710365206.608239&cid=C02NK2DQWUX

@puneetlath puneetlath changed the title [$250] Migrate index.js to function component [HOLD #33434][$250] Migrate index.js to function component Mar 21, 2024
@pac-guerreiro
Copy link
Contributor

@mkhutornyi @puneetlath

I'm currently migrating this file to typescript (#25151) and I already converted this component into a functional component.

If you want I can push my version along with the migration, otherwise I can wait for you @mkhutornyi if you already worked on it! 😄

@mkhutornyi
Copy link
Contributor

@pac-guerreiro please go ahead. @ishpaul777 can do C+ review on your PR.
Btw, are you already aware that this migration is on hold for #33434?

Looks like I am not needed anymore so unassigning, and also I haven't started yet.

@mkhutornyi mkhutornyi removed their assignment Mar 26, 2024
@pac-guerreiro
Copy link
Contributor

@mkhutornyi Thanks! Seems like that #33434 was merged yesterday 😄

@pac-guerreiro
Copy link
Contributor

@ishpaul777 This is my PR - #39011 - have fun! 😄

@puneetlath
Copy link
Contributor

Ok I'm going to just go ahead and close this issue out since it'll be handled as part of the TS migration for the component. Let me know if I've misunderstood!

@pac-guerreiro
Copy link
Contributor

@puneetlath you understood it correctly! 😄

@ishpaul777 ishpaul777 mentioned this issue Mar 28, 2024
Merged
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puneetlath puneetlath

@kadiealexander kadiealexander

@ishpaul777 ishpaul777

Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests