[HOLD for payment 2023-03-31] [$4000] Focus on the field does not shift while editing in the general settings page at the workspace.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open any workspace and go to general settings.
2. Now perform edit on workspace name (Do not save)
3. Notice that the cursor is focused on workspace name.
4. Now change the currency

Expected Result:

The focus on field should change in android too. I.e when selecting a new field, the cursor should also shift to that new field.

Actual Result:

Even After editing name field and moving to currency field, the cursor witha green line focus still remains on name field.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native

Version Number: 1.2.71-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Record_2023-02-12-14-21-57.1.mp4

az_recorder_20230213_170504.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676191167476849

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017b5fb21ef5da838a
• Upwork Job ID: 1627908747207131136
• Last Price Increase: 2023-03-07

[MelvinBot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~017b5fb21ef5da838a

[MelvinBot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[MelvinBot]

Triggered auto assignment to @tgolen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[anmurali]

Reproduced and slapped an external label on this to fix

[jayeshmangwani]

@anmurali is this not expected behavior?
this same behavior happens with all the form pages e.g. VBA > Company information page, focus any text input(Phone number) and then select company type(Picker) after selecting values from Picker, text input is still focused and Picker loses the focus

[ashimsharma10]

yes, I guess it occurs in a few more places. but how can such be intended? IMO focus should be on the field where the user is active.

[devanshujain95]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Focus needs to be shifted from Text input component once other component gets in focus (should get blurred).
Example as mentioned above: When user selects to change currency by selecting Picker component, keyboard and focus remains on its above component i.e. Text Input whereas Keyboard should get dismissed and focus should be shifted to Picker.

What is the root cause of that problem?

Picker component unable to close the keyboard when it gets in focus mode. Although Picker component is triggering its onFocus but unable to dismiss the keyboard. And hence, the prior text input component unable to get blurred.

What changes do you think we should make in order to solve the problem?

If we can somehow make our text input component trigger blur event whenever it gets out of focus, the focus will be removed and will be moved to next set of form components if any.

As @ashimsharma10 mentioned, this is happening everywhere where Picker component is used after Text Input component, and I checked my solution in other places like Company Information and this is fixed in all places :)

After Solution:

Screen.Recording.2023-02-21.at.5.17.00.PM.mov

[thesahindia]

@tgolen, I also think this is not a bug. It is the expected behaviour. Please close if you also feel the same.

[devanshujain95]

@thesahindia I think this should be consider as a bug because if we compare both iOS and Android platform, things are different. Also, focus should not be remain on the previous text input even when the user has moved to next form inputs.

[situchan]

I think we normally respect native platform's behavior. Android native Spinner modal doesn't focus itself at all as default.
Similar issue which was closed: #15230

[bernhardoj]

PR is ready for review.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• update react native picker select #16045

If no regressions arise, payment will be issued on 2023-03-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

This was not a bug caused by any regression. It was a platform inconsistency found in one of the third-party libraries that we use.

• [@thesahindia / @tgolen] The PR that introduced the bug has been identified. Link to the PR: NA
• [@thesahindia / @tgolen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
• [@thesahindia / @tgolen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@anmurali] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

@tgolen, @anmurali, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[tgolen]

I completed my pieces of the checklist and added this note:

This was not a bug caused by any regression. It was a platform inconsistency found in one of the third-party libraries that we use.

[thesahindia]

Regression test proposal

1. Go to Settings > Workspaces
2. Click on any existing workspace or create a new one
3. Go to general Settings
4. Focus on the name field
5. Notice that the name field gets highlighted
6. Click at the Default currency picker
7. Select any currency
8. Verify that the name field is not highlighted anymore

[tgolen]

@anmurali Looks like this is just waiting on you.

[tgolen]

bump @anmurali

[tgolen]

Bumping @anmurali 1:1

[anmurali]

Creating regression test - https://github.com/Expensify/Expensify/issues/275047

[tgolen]

I think this is completed now so closing it out.