Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-01-17] The text on the edit photo profile modal is not selectable #14121

Closed
2 of 6 tasks
mollfpr opened this issue Jan 8, 2023 · 12 comments
Closed
2 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@mollfpr
Copy link
Contributor

mollfpr commented Jan 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Regression from #14048 and soon will be deploy blocker

Action Performed:

  • Login to an account
  • Open the settings page
  • Go to the profile page by clicking on the profile picture or the account email
  • Click on the profile picture and click on the upload photo button
  • Select an image from your computer and the upload photo modal will open
  • Select the text on the modal Drag, zoom, and rotate your image to your preferred specifications by double click the text

Expected Result:

The text will be highlighted

Actual Result:

The text is not will be highlighted

Workaround:

NA

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.2.50-13
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @jatinsonijs
Slack conversation:

View all open jobs on GitHub

Screen.Recording.2023-01-08.at.19.57.21.mov
@mollfpr mollfpr added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 8, 2023

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@francoisl
Copy link
Contributor

francoisl commented Jan 9, 2023

Marking this a deploy blocker as discussed in the fix PR. There is already a staging checklist open so we'll need to CP the fix to staging.

cc @s77rt

@francoisl francoisl self-assigned this Jan 9, 2023
@francoisl francoisl added the DeployBlockerCash This issue or pull request should block deployment label Jan 9, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 9, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Jan 9, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Julesssss
Copy link
Contributor

I'm glad we have a PR open to resolve this unwanted change, but it hardly seems worthy of the deploy blocker label in my opinion. If the other blocker is resolved, I might remove the label here.

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Jan 10, 2023
@Julesssss
Copy link
Contributor

Okay, I resolved the only other blocker, so I'm going to remove the label here. Let's get it merged like a regular issue.

@Julesssss Julesssss added Weekly KSv2 Daily KSv2 and removed Hourly KSv2 Weekly KSv2 labels Jan 10, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jan 10, 2023
@melvin-bot melvin-bot bot changed the title The text on the edit photo profile modal is not selectable [HOLD for payment 2023-01-17] The text on the edit photo profile modal is not selectable Jan 10, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jan 16, 2023
@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 16, 2023
@mallenexpensify
Copy link
Contributor

@mollfpr , @jatinsonijs should be added to OP for reporting this regression bug, correct? And they're due $250 for the report
#13146 (comment)

@mallenexpensify
Copy link
Contributor

@sophiepintoraetz I added
Issue reported by: @jatinsonijs
Can you please hire and pay @jatinsonijs ? Thx

@sophiepintoraetz
Copy link
Contributor

Done!

@sophiepintoraetz
Copy link
Contributor

Payment is done so is there anything else keeping this issue open?

@francoisl
Copy link
Contributor

I don't think so, let's close!

@Expensify Expensify unlocked this conversation Jan 19, 2023
@mallenexpensify
Copy link
Contributor

@jatinsonijs I unlocked this issue, did you have a question about payment or is everything set?

@jatinsonijs
Copy link
Contributor

@mallenexpensify I have received reporting bonus, Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants