[HOLD for payment 2023-02-08] [$2000] Deep link routing is inconsistent when the app is open

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

1) Magic sign in Success

• Create a new account
• Kill the app
• Tap the magic sign in deep link
• After setting a password, you will be taken to the LHN, with the FAB modal opened ✅

2) Magic sign in Failure

• Create a new account
• Background, but do not kill the app
• Tap the magic sign in deep -ink
• After setting a password, you should be taken to the LHN, but the FAB will not be shown! ❌

3) Admin chat failure

• Sign in to an account without an open workspace
• Tap the fab button, and create a workspace
• Await the Notification from the support team member
• Do not kill the app
• Tap this notification
• You might be taken to the LHN (known, separate issue)
• Swipe right to the chat
• It should be the #admins chat, but is often an entirely different chat ❌

Solution

Figure out why the deep-links aren't working as expected while the app is open.

Actual Result :

on signin it navigates to chat screen with concierge

Workaround:

unknown

Platform:

Where is this issue occurring?

• Android

Version Number: 1.2.41-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen_Recording_20221217_122455_New.Expensify.mp4

screen-20221219-134725.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671280997504769

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0106e69a3f4a655640
• Upwork Job ID: 1612854400942157824
• Last Price Increase: 2023-01-25

[dylanexpensify]

On it

[dylanexpensify]

Started convo re: repro steps

[Julesssss]

Commented here. I believe this isn't worth fixing and will cease to be a problem after we rework our app navigation.

[dylanexpensify]

Closing as dupe for 9179

[Julesssss]

Based on our Slack discussion, that might be premature. I'm going to see if I can provide any evidence for my belief that it'll be resolved by our navigation changes.

[Julesssss]

After a lot of testing, I believe this is a good overview of deep linking:

Magic Sign in deep link

• If you kill the app before tapping the magic link, the FAB will always be shown ✅
• If you don’t kill the app before tapping the magic link, the FAB will never be shown ❌

Workspace message deep link

• If you kill the app before tapping the link, you will always be taken to the LHN, but technically the #admins chat is open. Swiping right will show it ✅ :
• If you don’t kill the app before tapping the link, there is no guarantee what will happen. Most of the time the behavior is the same as above, but sometimes you’ll be taken to the LHN, but with the Concierge chat shown when swiping right ❌ ❓

---

So, I believe there are two main problems here:

A) Because of this known issue, the user is taken to the LHN instead of the specific deep link chat. This is because of our weird navigation hierarchy, where both the LHN and Chat page are at the same level (mirroring web/Desktop). This will cease to be a problem once we implement the navigation improvements because LHN and the Chat pages will be completely separated
B) In addition, deep links do not always work correctly when the app is already open. This should be investigated further.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0106e69a3f4a655640

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

[trjExpensify]

Nice, thanks Jules. So it's this we focus on here right?

B) In addition, deep links do not always work correctly when the app is already open. This should be investigated further.

[JmillsExpensify]

Yikes, that one seems like quite the project, right? I'd want to make sure that we also consider whether there are broader improvements, and potentially even a refactor of sorts for consideration.

[tienifr]

@rushatgabhane @Julesssss @mountiny the PR is ready for review #14588
thanks!

[Julesssss]

Thanks for moving this forward all, I'm back and will test it today.

[situchan]

PR which fixes this issue caused regression of #11102

[Julesssss]

Yeah, I don't think it's a bad regression that would reduce payment, but I'm taking care of it here.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.63-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update use of allPolicies variable and push notification subscription to fix inconsistency in deep link routing #14588

If no regressions arise, payment will be issued on 2023-02-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @Julesssss] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @Julesssss] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @Julesssss] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@tienifr] Propose regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/260844

[Julesssss]

I wouldn't count this as a regression but is an overlooked case from the initial implementation (a very long time ago). So I checked off the relevant boxes. A regression test would be useful though.

[tienifr]

@rushatgabhane @Julesssss @mountiny

Regression Test Proposal

Bug: Deep link routing is inconsistent when the app is open

Proposed Test Steps:

• Open the app
• Login with an existing account that already has workspace / Login to an existing account then create a workspace
• Logout of the account
• Register with a new email
• Go back to home screen
• Perform 1 of the following
  • Keep the app in background
  • Kill the app in background
• Go to mailbox and click the magic sign-in link to access the set password page. Set a password and proceed
• Verify that the FAB modal is opened after signing in
• Select New workspace to create a new workspace
• Wait for the Notification from the support team member
• Perform 1 of the following
  • Keep the app in background
  • Kill the app in background
• Tap the notification
• Verify that the app navigates to the correct channel #admins

Do we 👍 or 👎

[Julesssss]

Yep that looks good, thanks. @dylanexpensify, all yours to check off

[dylanexpensify]

Looks great! Nice one @tienifr !

[dylanexpensify]

Added GH for test! Will begin payments tomorrow!

[dylanexpensify]

@tienifr sent offer! @rushatgabhane invited to apply to job!

[gadhiyamanan]

@dylanexpensify please send an offer for reporting bonus

[dylanexpensify]

@gadhiyamanan sent!
@rushatgabhane offer sent!

[dylanexpensify]

@rushatgabhane can you accept offer when you get the chance?
@gadhiyamanan sent offer for reporting!

[gadhiyamanan]

@dylanexpensify Accepted

[rushatgabhane]

@dylanexpensify accepted, thanks!

[dylanexpensify]

All paid out, thanks all!