Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - The keyboard overlaps with the "Sign in" button or covered it #13633

Closed
kbecciv opened this issue Dec 15, 2022 · 18 comments
Closed

mWeb - The keyboard overlaps with the "Sign in" button or covered it #13633

kbecciv opened this issue Dec 15, 2022 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Dec 15, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


issue found when executing PR #13529

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Sign out
  3. Tap or click on the email input element on the sign-in form to give it focus. Verify the keyboard comes up
  4. Click or tap outside of the input so that it loses focus
  5. Enter an email and click next
  6. Tap or click on the password input element on the sign-in form to give it focus

Expected Result:

The keyboard doesn't overlap with the "Sing in" button

Actual Result:

The keyboard overlaps with the "Sing in" button

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web (Android/Chrome)

Version Number: 1.240.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5865254_Record_2022-12-15-17-31-55.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 15, 2022

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Dec 15, 2022
@strepanier03
Copy link
Contributor

strepanier03 commented Dec 16, 2022

Bug0 Triage Checklist

Note: see this SO for more information.

  • The "bug" is actually a bug - It could be a design improvement so I'll raise internally if this can still be recreated by @kbecciv
  • The bug is not a duplicate report of an existing GH.
    • If it is, close the GH and add any novel details to the original GH instead
  • The bug is reproducible, following the reproduction steps.
    • If the GH doesn’t have steps to reliably reproduce the bug and you figure it out, then please add them.
    • If you’re unable to reproduce the bug, add the Needs reproduction label.
    • Comment on the issue outlining the steps you took to try to reproduce the bug, your results and tag the issue reporter and the Applause QA member who created the issue. Ask them to clarify reproduction steps and/or to check the reproduction steps again. Close issue.
  • The GH template is filled out as fully as possible
    • The GH body and title are clear (ie. could an external contributor understand it and work on it?)
  • The GH was created by an Expensify employee or a QA tester
  • If the bug is an OldDot issue, you should decide whether it is widespread enough to justify fixing or it is better to wait for reunification. If it’s better to wait, close the GH & provide this justification
  • If there's a link to Slack, check the discussion to see if we decided not to fix it
  • Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label

@strepanier03
Copy link
Contributor

@kbecciv -- I'm unable to reproduce this, I wonder if it's specific to the phone itself and not Android Chrome. I also wonder if this is a bug or a design improvement.


Phone model: Google Pixel 6
Custom keyboard: No

Screenshot_20221215-165006

Screenshot_20221215-165012

@strepanier03 strepanier03 added the Needs Reproduction Reproducible steps needed label Dec 16, 2022
@strepanier03
Copy link
Contributor

Head's up

I am out of the office starting December 17th and will return on January 3rd. During this time, if this GH needs action from a BugZero team member, please post in #expensify-open-source with a link to the GH to ask for some help.

Cheers! ☃️

@melvin-bot melvin-bot bot added the Overdue label Dec 19, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 Overdue labels Jan 2, 2023
@strepanier03
Copy link
Contributor

@kbecciv - Can you still reproduce this? I am unable to and am leaning towards closing for now until it can be.

@kbecciv
Copy link
Author

kbecciv commented Jan 5, 2023

Checking with team, will update you shortly

@strepanier03
Copy link
Contributor

Thank you, I'll check back in tomorrow.

@kbecciv
Copy link
Author

kbecciv commented Jan 6, 2023

Issue is reproduced with latest build 1.2.49.0

Record_2023-01-05-17-58-04.1.mp4

@tgolen tgolen changed the title mWeb - The keyboard overlaps with the "Sing in" button or covered it mWeb - The keyboard overlaps with the "Sign in" button or covered it Jan 6, 2023
@JmillsExpensify
Copy link

@strepanier03 Can you reproduce this on browser stack? I also tried and I wasn't able to on 1.2.50-14.

@JmillsExpensify JmillsExpensify added Daily KSv2 and removed Weekly KSv2 labels Jan 9, 2023
@trjExpensify
Copy link
Contributor

@kbecciv we should also confirm the device and try a couple to rule that out? Ty!

@tgolen
Copy link
Contributor

tgolen commented Jan 10, 2023

It's possible that the layout changes being discussed in #13876 will fix this issue.

@strepanier03
Copy link
Contributor

I tried the following devices in BrowserStack and was unable to reproduce the behavior in any of them.

  1. iPhone 14
  2. iPhone 8
  3. iPad pro 11 (2020)
  4. Samsung S22
  5. Google Pixel 4
  6. Huawei P30

@strepanier03
Copy link
Contributor

@kbecciv - I'll give you a bit to provide the reproduction steps with the device info. If we can't reliably reproduce by EOW I'll close this out.

@JmillsExpensify
Copy link

JmillsExpensify commented Jan 11, 2023

Interesting. Looking at the issue @tgolen linked, I think he's right. It appears that the issue/solution in #13876 will resolve this one.

@kbecciv
Copy link
Author

kbecciv commented Jan 11, 2023

@strepanier03 Checking with team, update you shortly

@kbecciv
Copy link
Author

kbecciv commented Jan 11, 2023

Tester device information:

Screenshot_2023-01-11-17-33-33-40_fc704e6b13c4fb26bf5e411f75da84f2

@JmillsExpensify
Copy link

Interesting, given that @strepanier03 is unable to reproduce on common Android devices, I'm fairly inclined to close the issue.

@strepanier03
Copy link
Contributor

I agree. We can always reopen this in the future if it starts appearing on common android and iOS devices. Closing for now.

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

5 participants