-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOS - Workspace - App is crashed when delete the Workspace offline #13198
Comments
Triggered auto assignment to @Christinadobrzyn ( |
I think this might be related to this online/offline issue #12775 @stitesExpensify could you give a buddy check? |
Hmm it's definitely very similar, but I think it's different than that issue because this isn't showing a "replay", this is the app actually crashing |
I am not able to reproduce this. Additionally, I'm seeing a different UI than in the video. In mine, when we delete a workspace offline, it gets crossed out in the list which I don't see in the OP. I think this was fixed by an API refactor. RPReplay_Final1669996601.mp4 |
@kbecciv can you confirm this is still reproducible for you? |
Still trying to repro this |
I can't reproduce this but I don't really understand the steps and also, I'm not sure what this is solving - would this happen in the 'real world' or does this relate to something else? |
Yep! Every action should be able to be performed offline without any problems when coming back online to give a more fluid user experience. The problem isn't really as much that a user is fully offline, but what if their cell service is spotty and they try to delete a workspace, and then their app suddenly crashes? To the user it would seem like our app is just broken! Sorry if that was over-explained, I just wanted to give an overview of why the "offline first" mentality applies here :) |
That being said, i'm going to close this since neither of us can reproduce it |
@stitesExpensify Checking again with current build. |
Issue is not reproduced with build 1.2.36.2 RPReplay_Final1670447573.MP4 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Precondition: Create a WS in Android app and delete it ( do it online and offline)
Expected Result:
App is not crashed when delete the Workspace offline
Actual Result:
App is crashed when delete the Workspace offline
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.34.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
RPReplay_Final1669821239.1.MP4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: