[HOLD for payment 2022-12-08] Workspace - Delete workspace error icon & message do not appear for failed scenario

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Access staging.new.expensify.com
2. Log into an account that has the necessary pre conditions [email protected]
3. Navigate to Workspaces > Error Test
4. Disable the internet connection in the device
5. Click/Tap on the 3 dots and select "Delete Workspace"
6. Confirm the modal to delete the workspace
7. Verify the workspace is now displayed with a strikethrough indicating it will be deleted when back online
8. Enable the internet connection in the device

Expected Result:

User should see a red dot on the profile icon and the workspace has an error below indicating "You cannot delete this workspace because it's set as the domain restricted one for a domain security group"

Actual Result:

The user sees a red dot on the profile icon but the user does not see any error message on the workspace setting. The workspace that was deleted when offline also no longer shows

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.34.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5842354_No_error_message_is_seen.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[aldo-expensify]

The backend is responding with the expected error:

[aldo-expensify]

The policy is still in Onyx, with the error, this looks fine...

[aldo-expensify]

This may be the PR that caused the regression: #12971

I'm not sure why it is intentionally filtering out workspaces that have pending action 'delete':

[aldo-expensify]

cc @jasperhuangg

[aldo-expensify]

Closed by mistake

[luacmartins]

Fix was merged. Closing this issue!

[luacmartins]

Thanks for the quick work @aldo-expensify!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert filtering out workspaces with pending delete action #13201

If no regressions arise, payment will be issued on 2022-12-08. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty