Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate off of findNodeHandle #11635

Closed
roryabraham opened this issue Oct 6, 2022 · 2 comments
Closed

Migrate off of findNodeHandle #11635

roryabraham opened this issue Oct 6, 2022 · 2 comments
Assignees
@parasharrajat @roryabraham @zanyrenney
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Task

Comments

@roryabraham
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Problem

According to the official docs, we cannot turn on Fabric (RN new architecture) without first migrating away all uses of findNodeHandle

Solution

Migrate away from usages of findNodeHandle. We currently only have one in BaseOptionSelector here

View all open jobs on GitHub
@roryabraham roryabraham self-assigned this Oct 6, 2022
This was referenced Oct 6, 2022
Closed
Merged
@roryabraham roryabraham added Internal Requires API changes or must be handled by Expensify staff ContributorPlusReview labels Oct 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 7, 2022

Triggered auto assignment to @zanyrenney for Upwork job creation (chore: ContributorPlusReview), see https://stackoverflow.com/c/expensify/questions/13732 for more details.

@roryabraham
Copy link
Contributor Author

ContributorPlusReview label didn't work here, so I'm manually tagging in @parasharrajat for review since he reviewed this code originally.

@roryabraham roryabraham added the Reviewing Has a PR in review label Oct 7, 2022
@melvin-bot melvin-bot bot closed this as completed Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parasharrajat parasharrajat

@roryabraham roryabraham

@zanyrenney zanyrenney

Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Task
Projects
No open projects
RN: New Architecture
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@parasharrajat @roryabraham @zanyrenney