Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] codecov GH action doesn't work with PRs from forks #517

Closed
dariuszkuc opened this issue Dec 16, 2019 · 3 comments · Fixed by #798
Closed

[build] codecov GH action doesn't work with PRs from forks #517

dariuszkuc opened this issue Dec 16, 2019 · 3 comments · Fixed by #798
Labels
type: tool update CI, code coverage, or linter updates

Comments

@dariuszkuc
Copy link
Collaborator

Describe the bug
Currently GH actions do not allow sharing secrets to build from forks (including PRs). This means that currently it is not possible to correctly integrate with codecov.io (which requires secret token) using GH actions.

Expected behavior
Codecov coverage diff is calculated for all PRs

Related
@dariuszkuc dariuszkuc added type: bug Something isn't working type: tool update CI, code coverage, or linter updates labels Dec 16, 2019
@dariuszkuc
Copy link
Collaborator Author

Alternative -> migrate back to use Travis until GH action can support this functionality

@dariuszkuc
Copy link
Collaborator Author

Another alternative -> enforce min coverage limits through Jacoco. We probably should do this anyway.

@dariuszkuc dariuszkuc changed the title Codecov GH action doesn't work with PRs from forks [build] codecov GH action doesn't work with PRs from forks Dec 16, 2019
@smyrick smyrick removed the type: bug Something isn't working label Feb 22, 2020
@dariuszkuc
Copy link
Collaborator Author

Looks like Codecov now supports tokenless uploads -> codecov/codecov-action#29 (comment)

@smyrick smyrick mentioned this issue Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: tool update CI, code coverage, or linter updates
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove codecov reports and links smyrick/graphql-kotlin
2 participants
@smyrick @dariuszkuc