Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded cooldown value #97

Open
teamon opened this issue Jan 15, 2025 · 0 comments
Open

Hardcoded cooldown value #97

teamon opened this issue Jan 15, 2025 · 0 comments

Comments

@teamon
Copy link

teamon commented Jan 15, 2025

I'm been reading the leaky bucket implementation and I've noticed that there is a fixed value of 1000 returned in case the request is denied (https://github.com/ExHammer/hammer-backend-redis/blob/master/lib/hammer/redis/leaky_bucket.ex#L90)

Given the redis script return the number of milliseconds, should it be used instead of the fixed 1000?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teamon