v0.1.0 (#236)

* updated submodule for NP to v0.5.0 release commit

* updated NESO-Spack submodule to main

* fixed bad error code checking in generic hdf5 writer

* bugfix replaced numeric_limits::min with the correct numeric_limits::lowest

* updated NESO-Spack submodule

* Update nektar version number to reflect NESO-Spack change.

---------

Co-authored-by: Owen Parry <[email protected]>

include/nektar_interface/bounding_box_intersection.hpp

@@ -67,7 +67,7 @@ inline void reset_bounding_box(std::array<double, ARRAY_LENGTH> &bounding_box) {
 
   for (int dimx = 0; dimx < ndim; dimx++) {
     bounding_box[dimx] = std::numeric_limits<double>::max();
-    bounding_box[dimx + ndim] = std::numeric_limits<double>::min();
+    bounding_box[dimx + ndim] = std::numeric_limits<double>::lowest();
   }
 }
 
@@ -206,7 +206,7 @@ class MeshHierarchyBoundingBoxIntersection {
     // owned cells.
     for (int dimx = 0; dimx < 3; dimx++) {
       this->bounding_box[dimx] = std::numeric_limits<double>::max();
-      this->bounding_box[dimx + 3] = std::numeric_limits<double>::min();
+      this->bounding_box[dimx + 3] = std::numeric_limits<double>::lowest();
     }
     const int num_cells = owned_cells.size();
     this->bounding_boxes.resize(num_cells);

include/nektar_interface/cell_id_translation.hpp

@@ -40,7 +40,7 @@ class CellIDTranslation {
   inline void construct_maps(std::map<int, std::shared_ptr<T>> &geoms) {
     const int nelements = geoms.size();
     int id_min = std::numeric_limits<int>::max();
-    int id_max = std::numeric_limits<int>::min();
+    int id_max = std::numeric_limits<int>::lowest();
 
     this->map_to_nektar.resize(nelements);
     this->dh_map_to_geom_type.realloc_no_copy(nelements);

include/nektar_interface/particle_boundary_conditions.hpp

@@ -64,7 +64,7 @@ class NektarCartesianPeriodic {
     double extent[3];
     for (int dimx = 0; dimx < 3; dimx++) {
       origin[dimx] = std::numeric_limits<double>::max();
-      extent[dimx] = std::numeric_limits<double>::min();
+      extent[dimx] = std::numeric_limits<double>::lowest();
     }
 
     for (auto &vx : verticies) {

include/nektar_interface/particle_mesh_interface.hpp

@@ -514,7 +514,7 @@ class ParticleMeshInterface : public HMesh {
 
     // Compute a set of coarse mesh sizes and dimensions for the mesh hierarchy
     double min_extent = std::numeric_limits<double>::max();
-    double max_extent = std::numeric_limits<double>::min();
+    double max_extent = std::numeric_limits<double>::lowest();
     for (int dimx = 0; dimx < this->ndim; dimx++) {
       const double tmp_global_extent =
           this->global_bounding_box[dimx + 3] - this->global_bounding_box[dimx];

solvers/Electrostatic2D3V/Diagnostics/generic_hdf5_writer.hpp

@@ -1,6 +1,7 @@
 #ifndef __GENERIC_HDF5_WRITER_H_
 #define __GENERIC_HDF5_WRITER_H_
 
+#include <LibUtilities/BasicUtils/ErrorUtil.hpp>
 #include <hdf5.h>
 #include <string>
 
@@ -12,7 +13,9 @@ class GenericHDF5Writer {
   hid_t group_steps;
   hid_t group_step;
   hid_t group_global;
-  inline void ghw_H5CHK(const bool flag) { ASSERTL1((cmd) >= 0, "HDF5 ERROR"); }
+  inline void ghw_H5CHK(const bool flag) {
+    ASSERTL0((flag) >= 0, "HDF5 ERROR");
+  }
 
   inline void write_dataspace(hid_t group, std::string key, hid_t dataspace,
                               double *value) {
@@ -52,7 +55,7 @@ class GenericHDF5Writer {
       : filename(filename), step(-1), group_step(-1) {
     this->file = H5Fcreate(this->filename.c_str(), H5F_ACC_TRUNC, H5P_DEFAULT,
                            H5P_DEFAULT);
-    ASSERTL1(this->file != H5I_INVALID_HID, "Invalid HDF5 file identifier");
+    ASSERTL0(this->file != H5I_INVALID_HID, "Invalid HDF5 file identifier");
     // Create the group for global data.
     std::string group_name = "global_data";
     this->group_global = H5Gcreate(this->file, group_name.c_str(), H5P_DEFAULT,

spack.yaml

@@ -31,6 +31,6 @@ spack:
       path: .
       spec: neso@working
     nektar:
-      spec: nektar@5.2.0-2022-09-03
+      spec: nektar@5.3.0-2022-09-03
     neso-particles:
       spec: neso-particles@working

test/unit/nektar_interface/test_particle_geometry_interface.cpp

@@ -63,7 +63,7 @@ TEST(ParticleGeometryInterface, BoundingBox) {
   std::array<double, 6> bounding_box;
   for (int dimx = 0; dimx < 3; dimx++) {
     bounding_box[dimx] = std::numeric_limits<double>::max();
-    bounding_box[dimx + 3] = std::numeric_limits<double>::min();
+    bounding_box[dimx + 3] = std::numeric_limits<double>::lowest();
   }
 
   expand_bounding_box(e0, bounding_box);