Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use autoprefixer #63

Open
barrysteyn opened this issue Jun 14, 2016 · 2 comments
Open

Use autoprefixer #63

barrysteyn opened this issue Jun 14, 2016 · 2 comments

Comments

@barrysteyn
Copy link

For example, in a less file:

-webkit-flex: 0 0 auto;
-ms-flex: 0 0 auto;
-webkit-box-flex: 0;
flex: 0 1 auto;

With autoprefixer, the above can be shortened down to the last line, and in a "post compilation" stage, the prefixes will be added. For example, look at this: https://github.com/postcss/autoprefixer#flexbox-filters-etc - it highlights this very example. This will make the less files much easier to maintain and read.

@hetmann
Copy link
Contributor

hetmann commented Jun 14, 2016

@barrysteyn thanks for the suggestion, @birledan will see this and try it out.

@barrysteyn
Copy link
Author

So autoprefixer can also be plugged in directly to webpack. It's part of the new postcss revolution (infact, it started it). However, now that I have your guys ears, can I ask some questions/make some suggestions:

  1. The /lib and /src folders seem identical (at least just by looking at the block Grid component). What gives?
  2. I suspect there is a mixture of spaces and tabs in the less files. Please can we only use spaces: It will then render in an IDE perfectly, no matter what platform.
  3. What I would like to do is include unprocessed files (for example, less files that have not been through the autoprefixer) inside my webpack. So could we have source that has not been built in anyway. Maybe that could be in the src folder, and once webpack (or whatever you use) to build the css and react stuff, it could go to the /lib folder?

What do you guys think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants