Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: add alias support #3342

Merged
merged 1 commit into from
Nov 21, 2024

[FEAT] connect: add alias support

3402dc6
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] connect: add alias support #3342

[FEAT] connect: add alias support
3402dc6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 21, 2024 in 0s

77.35% (-0.10%) compared to f6eb993

View this Pull Request on Codecov

77.35% (-0.10%) compared to f6eb993

Details

Codecov Report

Attention: Patch coverage is 26.00000% with 259 lines in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (f6eb993) to head (3402dc6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/translation/datatype.rs 7.40% 100 Missing ⚠️
...-connect/src/translation/logical_plan/aggregate.rs 0.00% 44 Missing ⚠️
src/daft-connect/src/translation/literal.rs 0.00% 33 Missing ⚠️
...onnect/src/translation/expr/unresolved_function.rs 0.00% 31 Missing ⚠️
src/daft-connect/src/translation/expr.rs 54.38% 26 Missing ⚠️
...daft-connect/src/translation/logical_plan/range.rs 62.50% 18 Missing ⚠️
src/daft-dsl/src/lit.rs 0.00% 3 Missing ⚠️
src/daft-connect/src/translation/logical_plan.rs 33.33% 2 Missing ⚠️
src/daft-connect/src/lib.rs 80.00% 1 Missing ⚠️
...ft-connect/src/translation/logical_plan/project.rs 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3342      +/-   ##
==========================================
- Coverage   77.44%   77.35%   -0.10%     
==========================================
  Files         678      685       +7     
  Lines       83309    83629     +320     
==========================================
+ Hits        64519    64689     +170     
- Misses      18790    18940     +150     
Files with missing lines Coverage Δ
src/daft-connect/src/translation/schema.rs 100.00% <100.00%> (+100.00%) ⬆️
src/daft-connect/src/lib.rs 64.21% <80.00%> (+14.45%) ⬆️
...ft-connect/src/translation/logical_plan/project.rs 88.88% <88.88%> (ø)
src/daft-connect/src/translation/logical_plan.rs 61.53% <33.33%> (-2.26%) ⬇️
src/daft-dsl/src/lit.rs 56.28% <0.00%> (-0.49%) ⬇️
...daft-connect/src/translation/logical_plan/range.rs 62.50% <62.50%> (ø)
src/daft-connect/src/translation/expr.rs 54.38% <54.38%> (ø)
...onnect/src/translation/expr/unresolved_function.rs 0.00% <0.00%> (ø)
src/daft-connect/src/translation/literal.rs 0.00% <0.00%> (ø)
...-connect/src/translation/logical_plan/aggregate.rs 0.00% <0.00%> (ø)
... and 1 more

... and 7 files with indirect coverage changes

---- 🚨 Try these New Features: