[FEAT] connect: add alias support

[andrewgazelka]

To be "fully" 1:1 will need

• [FEAT] Basic global expressions within expression tree #1979

[andrewgazelka]

• [FEAT] connect: add alias support #3342 : 7 dependent PRs (#3344 , #3345 , #3348 and 4 others) 👈 (View in Graphite)
• [FEAT] consolidate Spark session fixture into conftest.py #3341 : 3 other dependent PRs (#3309 , #3326 , #3343 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #3342 will degrade performances by 18.45%

_{Comparing andrew/connect-alias (3402dc6) with main (2c0f3cd)}

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	andrew/connect-alias	Change
❌	test_iter_rows_first_row[100 Small Files]	289.2 ms	354.7 ms	-18.45%

[codecov]

Codecov Report

Attention: Patch coverage is 26.00000% with 259 lines in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (f6eb993) to head (3402dc6).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/daft-connect/src/translation/datatype.rs	7.40%	100 Missing ⚠️
...-connect/src/translation/logical_plan/aggregate.rs	0.00%	44 Missing ⚠️
src/daft-connect/src/translation/literal.rs	0.00%	33 Missing ⚠️
...onnect/src/translation/expr/unresolved_function.rs	0.00%	31 Missing ⚠️
src/daft-connect/src/translation/expr.rs	54.38%	26 Missing ⚠️
...daft-connect/src/translation/logical_plan/range.rs	62.50%	18 Missing ⚠️
src/daft-dsl/src/lit.rs	0.00%	3 Missing ⚠️
src/daft-connect/src/translation/logical_plan.rs	33.33%	2 Missing ⚠️
src/daft-connect/src/lib.rs	80.00%	1 Missing ⚠️
...ft-connect/src/translation/logical_plan/project.rs	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3342      +/-   ##
==========================================
- Coverage   77.44%   77.35%   -0.10%     
==========================================
  Files         678      685       +7     
  Lines       83309    83629     +320     
==========================================
+ Hits        64519    64689     +170     
- Misses      18790    18940     +150     

Files with missing lines	Coverage Δ
src/daft-connect/src/translation/schema.rs	100.00% <100.00%> (+100.00%)	⬆️
src/daft-connect/src/lib.rs	64.21% <80.00%> (+14.45%)	⬆️
...ft-connect/src/translation/logical_plan/project.rs	88.88% <88.88%> (ø)
src/daft-connect/src/translation/logical_plan.rs	61.53% <33.33%> (-2.26%)	⬇️
src/daft-dsl/src/lit.rs	56.28% <0.00%> (-0.49%)	⬇️
...daft-connect/src/translation/logical_plan/range.rs	62.50% <62.50%> (ø)
src/daft-connect/src/translation/expr.rs	54.38% <54.38%> (ø)
...onnect/src/translation/expr/unresolved_function.rs	0.00% <0.00%> (ø)
src/daft-connect/src/translation/literal.rs	0.00% <0.00%> (ø)
...-connect/src/translation/logical_plan/aggregate.rs	0.00% <0.00%> (ø)
... and 1 more

... and 7 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[graphite-app]

The handle_count function needs to support both count(*) and count(expr) cases. Currently it only handles the single argument case. For zero arguments (i.e. count(*)), it should return a count of all rows. For one argument (i.e. count(expr)), it should count non-null values of that expression.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

Graphite Automations

"Notify author when CI fails" took an action on this PR • (11/21/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

[andrewgazelka]

Merge activity

• Nov 20, 8:59 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..