Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to write a .geom file based on an existing one #144

Open
takluyver opened this issue Mar 1, 2022 · 0 comments · May be fixed by #149
Open

Method to write a .geom file based on an existing one #144

takluyver opened this issue Mar 1, 2022 · 0 comments · May be fixed by #149
Labels
enhancement New feature or request

Comments

@takluyver
Copy link
Member

Prompted by discussion with @turkot on PR #114:

EXtra-geom has methods to read and write .geom files, but any information that we want to write back out must be parsed, kept as metadata, and serialised again. This is tricky, because the CrystFEL geometry format is designed to be human writable: comments are used generously, panels can have arbitrary names, there are different ways to specify the same values, etc. All this flexibility is good for human editors, but more work to handle automatically.

Tom White's scripts (e.g. transfer-geom) get round this by using an existing geom file as a basis, and only replacing specific parts. We could do something similar with data from an EXtra-geom object.

What should it modify? My initial thought is to replace only the fields relating to positions (corner_x, corner_y, coffset, ss and fs). I suspect that trying to do anything else gets complicated quickly.

@takluyver takluyver added the enhancement New feature or request label Mar 1, 2022
@takluyver takluyver linked a pull request Mar 18, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant