Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Move all renderer associated objects from Engine to EngineRenderer #5836

Merged
merged 4 commits into from
Apr 24, 2022

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Apr 23, 2022

Summary

  • fixes a problem with ts config making imports annoying
  • moves all renderer associated objects from Engine to EngineRenderer
  • clean up a few unnecessary objects on Engine object

References

part of #5834

Checklist

  • CI/CD checks pass npm run check
    • Linter passing via npm run lint
    • Typescript passing via npm run check-errors
    • Unit & Integration tests passing via npm run test
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@HexaField HexaField requested review from speigg and NPatel10 April 23, 2022 09:30
@HexaField HexaField merged commit cc60479 into dev Apr 24, 2022
@HexaField HexaField deleted the engine-renderer-refactor branch April 24, 2022 01:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants