[Draft] Feature/noid/month multiselect #797
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhinton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the selection of multiple days in the monthview, which then get shown in the weekview-style.
Currently it can do:
Select range in single week
Select range in multiple weeks
Highlight Selection
Block Listview from moving while selection is beeing made
Fix limit beeing applied even when selection is smaller than limit
Currently the logic works, it calculates the selected elements from the relative position of the first click to the position where it was released. It then checks wether the selection was made backwards in time or not, calculates the appropriate timestamps, and then recalculates the timestamp according to the limit which can be adjusted via a LIMIT_SELECTION constant (which is currently set to 14 days.
The last thing that is missing (besides refactoring&cleanup) is visual feedback. It marks everything that is in the same row properly, but the other rows are currently unaffected, i have to find out how to do that.
This could be further improved by #761