overhauled about-fragment to make it less cramped #760
Conversation
|
Can you improve the horizontal layout? This looks broken with your patch: |
|
I haven't tested this yet, but now we have 200 lines more code and two files instead of one. |
|
yup, that is expected. I created a landscape version of the about xml, because just stacking everything on top of each other does not look good. So i basically created two adjacent "stacks" that display the information, and therefore a new file was required |
|
Can you provide screenshots before/after and resolve string.xml conflict please. |
|
@Gitsaibot i have added screenshots and rebased my branch. The huge statusbar is an artifact of the emulator |
|
This is not rebased. Your PR has 284 commits! I can't check it in this state. |
newhinton
force-pushed
the
feature/noid/about_overhaul
branch
2 times, most recently
from
1abf3c4 to
2303365
Compare
# Conflicts: # res/layout/about.xml # res/values/strings.xml
|
@Gitsaibot This should resolve the conflicts |
|
Icons white, copyright text at different position (portrait/landscape), text spacing different |
No description provided.