Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mnemonic validation on wallet creation #85

Merged
merged 1 commit into from
May 24, 2021

Conversation

Esya
Copy link
Contributor

@Esya Esya commented May 24, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #85 (901d2f0) into develop (b260ba2) will decrease coverage by 0.27%.
The diff coverage is 95.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #85      +/-   ##
===========================================
- Coverage    92.10%   91.82%   -0.28%     
===========================================
  Files           93       94       +1     
  Lines         1557     1614      +57     
  Branches       261      270       +9     
===========================================
+ Hits          1434     1482      +48     
- Misses         123      132       +9     
Flag Coverage Δ
cypress 66.26% <94.02%> (+0.21%) ⬆️
jest 75.95% <71.64%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/pages/AccountPage/index.tsx 100.00% <ø> (ø)
...ges/OpenWalletPage/Features/FromMnemonic/index.tsx 100.00% <ø> (ø)
src/app/pages/CreateWalletPage/index.tsx 96.15% <90.00%> (-3.85%) ⬇️
src/app/components/MnemonicValidation/index.tsx 95.91% <95.91%> (ø)
src/app/components/MnemonicGrid/index.tsx 100.00% <100.00%> (ø)
src/app/pages/CreateWalletPage/slice/index.ts 100.00% <100.00%> (ø)
src/app/state/wallet/index.ts 76.00% <0.00%> (-12.00%) ⬇️
src/app/components/Sidebar/index.tsx 84.84% <0.00%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b260ba2...901d2f0. Read the comment docs.

@Esya Esya force-pushed the feat/mnemonic-validation branch from 9b105ee to 901d2f0 Compare May 24, 2021 15:36
@Esya Esya merged commit acb2ed1 into develop May 24, 2021
Esya pushed a commit that referenced this pull request May 24, 2021
# [1.0.0-dev.5](v1.0.0-dev.4...v1.0.0-dev.5) (2021-05-24)

### Features

* mnemonic validation on wallet creation ([#85](#85)) ([acb2ed1](acb2ed1)), closes [#13](#13)
@Esya
Copy link
Contributor Author

Esya commented May 24, 2021

🎉 This PR is included in version 1.0.0-dev.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Esya Esya deleted the feat/mnemonic-validation branch May 24, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant