Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub-common): add arcgisHubConfig global variable #1820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomwayson
Copy link
Member

@tomwayson tomwayson commented Feb 27, 2025

Issue: https://devtopia.esri.com/dc/hub/issues/10713

affects: @esri/hub-common

  1. Description:

Adds globalThis.arcgisHubConfig to enable consumers to configure Hub.js before using it. It currently has one setting: logLevel, ex:

// in application initialization
const logLevel = isProduction ? 'error' : 'debug'
globalThis.arcgisHubConfig = { logLevel }
// start using Hub.js

See https://devtopia.esri.com/dc/hub/issues/10713#issuecomment-5337749 for more details.

  1. Instructions for testing:

  2. Closes Issues: # (if appropriate)

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@tomwayson tomwayson requested a review from dbouwman February 27, 2025 16:14
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (27c08b8) to head (a42d7c3).
Report is 39 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #1820    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files         1035      1055    +20     
  Lines        18879     19204   +325     
  Branches      3450      3474    +24     
==========================================
+ Hits         18879     19204   +325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants