refactor(menu-item,menu): keyboard interaction #6819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -172,8 +177,6 @@ export class CalciteMenuItem implements LoadableComponent { | |||
| this.active = this.active || this.editable; | |||
| this.isFocused = this.active; | |||
| // todo just get any nav items in the default slot? | |||
| // this.hasSubMenu = this.hasSlottedItems(); | |||
|
|
|||
| // for now to detect nesting only working two level for demo.need to just check if it has any parent originating at top lvel | |||
There was a problem hiding this comment.
Can we remove any todo / wip items (I think these are probably mine, ha)
There was a problem hiding this comment.
i left them to keep a track of whats leftover. Are these irrelevant?
| @@ -504,9 +398,8 @@ export class CalciteMenuItem implements LoadableComponent { | |||
| : "chevron-down" | |||
| : dirChevron | |||
| } | |||
| onClick={() => (this.open = !this.open)} | |||
| onClick={this.clickHandler} | |||
anveshmekala
deleted the
anveshmekala/refactor-keyboard-support-menu-item
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6531
Summary
Refactors keyboard navigation and cleanup