-
Notifications
You must be signed in to change notification settings - Fork 107
Fix NPM release #154
Comments
the plot thickens npm installs are indeed installing files on other machines. Blank folder above was related to issue in my env (which uses npm link). However, there is no dist folder in the install. That is why this doesn't work: https://npmcdn.com/[email protected]/dist/angular-esri-map.js But this does: https://npmcdn.com/[email protected]/src/core/esriLoader.js However, since I'm using roughly the same build script as esri-leaflet, I'd expect these to fail: https://npmcdn.com/[email protected]/dist/esri-leaflet.js But they work. |
Furthermore, the dist folder and all files are in that release on GH: |
Booyah - I think it's this: https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package Need to try adding a an .npmignore file. Looks like the way esri-leaflet does it is by including everything that .gitignore has except dist. |
Should be fixed in 8f60281. Need to publish a new version to test. |
Looks like RC2 release didn't include the dist folder either. I can't figure out why? It wasn't even on my local file system after running the release script (which errored out as usual). |
For future reference, the second issue (dist folder not on local file system or in release) was due to |
At first I was noticing that after running
npm install angular-esri-map
all that I would see under node_modules/angular-esri-map is index.html and bower_components - wat???See: https://twitter.com/tomwayson/status/666988609560539136
So I ran
npm publish
and now after runningnpm install angular-esri-map
I get a blank folder.Ugggggggggggggghhhhhhhhhhh!!!
The text was updated successfully, but these errors were encountered: