Add basic test for DPCTxnNote #1
Merged
+324
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will remove fee and fee change and collect detailed benchmark data on another branch, as discussed. |
|
This is pending an PR on upstream Jellyfish to support ☝️ being done by @zhenfeizhang |
zhenfeizhang
approved these changes
May 14, 2022
| /// Get the number of constraints in the underlying `PredicateCircuit` | ||
| fn num_constraints(&self) -> usize { | ||
| // TODO: (alex) poor API design, can't get a immutable reference to the | ||
| // underlying `PlonkCircuit`/`Instance` in jf-plonk |
There was a problem hiding this comment.
is this the padded version or the unpadded one? Shall we patch Jellyfish?
There was a problem hiding this comment.
this is padded version. the unpadded version num of constraint is printed here.
I think we don't need to patch Jellyfish, since our circuit is built and finalized outside of Jellyfish, so the downstream libraries can print out the raw/unpadded num_of_constraint in their code.
alxiong
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
DPCTxnBody::generate()API design to acceptlocal_data_commitment_randomnesssince the predicates it accepts are assumed to finalized outside this function.Outdated:
See notion page on the benchmark effort.