Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Decrease size of roots array in the CAPE contract #1055

Closed
philippecamacho opened this issue May 17, 2022 · 3 comments · Fixed by #1066
Closed

Decrease size of roots array in the CAPE contract #1055

philippecamacho opened this issue May 17, 2022 · 3 comments · Fixed by #1066
Assignees
Labels
contract priority: high High priority task

Comments

@philippecamacho
Copy link
Collaborator

Currently set to 1000. This causes the wallet to take a lot of time to recover from a transaction being rejected.
1000 is too much, 10 sounds too little (@sveitser: "If the system were really busy this corresponds to 3-4 ethereum blocks. Or about 1 minute."), how many roots should we keep in the contract?

@philippecamacho
Copy link
Collaborator Author

What about 20? @jbearer @sveitser

@philippecamacho philippecamacho self-assigned this May 17, 2022
@nyospe
Copy link
Contributor

nyospe commented May 17, 2022

50 seems like a reasonable to conservative length. Five minutes. 20 feels on the short end of reasonable.

@philippecamacho
Copy link
Collaborator Author

40

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contract priority: high High priority task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants