From 5117247edd572349569c4141a2d5448f38c8542e Mon Sep 17 00:00:00 2001
From: joncrall <erotemic@gmail.com>
Date: Sun, 28 Apr 2024 19:28:51 -0400
Subject: [PATCH] wip

---
 CMakeLists.txt           | 2 +-
 dev/build_base_docker.py | 4 ++++
 pyproject.toml           | 5 +++++
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index c2e6089..0f47a22 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.1.0)
+cmake_minimum_required(VERSION 3.5.0)
 
 set(CMAKE_CXX_STANDARD 11)
 
diff --git a/dev/build_base_docker.py b/dev/build_base_docker.py
index 60af9ba..96f599d 100755
--- a/dev/build_base_docker.py
+++ b/dev/build_base_docker.py
@@ -302,6 +302,10 @@ def main():
 
             docker tag {OUR_IMAGE_NAME} {OUR_DOCKER_URI}
             docker push {OUR_DOCKER_URI}
+
+            # Note you will likely need to make the image public on quay.io if
+            # you have not done so already
+            # https://quay.io/repository/erotemic/{OUR_IMAGE_BASE}?tab=settings
             '''), 'bash'))
 
 
diff --git a/pyproject.toml b/pyproject.toml
index 928f63d..12d57c6 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -2,6 +2,11 @@
 requires = [ "setuptools>=41.0.1", "scikit-build>=0.11.1", "numpy", "ninja>=1.10.2", "cmake>=3.21.2", "cython>=0.29.24",]
 
 [tool.cibuildwheel]
+
+# TODO: abi3 wheels
+# https://scikit-build-core.readthedocs.io/en/latest/configuration.html
+# https://cibuildwheel.pypa.io/en/stable/faq/#abi3
+
 build = "cp37-* cp38-* cp39-* cp310-* cp311-* cp312-*"
 build-frontend = "build"
 skip = "pp* cp27-* cp34-* cp35-* cp36-* *-musllinux_* *i686*"