The method getHeadersArray doesn't seem to check the path.parameters object it just skips to path path[method].parameters

[michaelgwelch]

This can be seen here:

openapi-snippet/openapi-to-har.js

Lines 369 to 386 in 2e6c2c9

	const getHeadersArray = function (openApi, path, method) {
	const headers = [];
	const pathObj = openApi.paths[path][method];
	// 'accept' header:
	if (typeof pathObj.consumes !== 'undefined') {
	for (let i in pathObj.consumes) {
	const type = pathObj.consumes[i];
	headers.push({
	name: 'accept',
	value: type,
	});
	}
	}
	// headers defined in path object:
	if (typeof pathObj.parameters !== 'undefined') {
	for (let k in pathObj.parameters) {

Another issue is that the getFullPath method assumes that only one or the other will have entries.

openapi-snippet/openapi-to-har.js

Lines 335 to 338 in 2e6c2c9

	const getFullPath = function (openApi, path, method) {
	let fullPath = path;
	const parameters =
	openApi.paths[path].parameters || openApi.paths[path][method].parameters;

Finally getQueryStrings appears to do it correctly and checks both:

openapi-snippet/openapi-to-har.js

Lines 302 to 316 in 2e6c2c9

	if (typeof openApi.paths[path].parameters !== 'undefined') {
	pathQueryStrings = parseParametersToQuery(
	openApi,
	openApi.paths[path].parameters,
	values
	);
	}
	if (typeof openApi.paths[path][method].parameters !== 'undefined') {
	methodQueryStrings = parseParametersToQuery(
	openApi,
	openApi.paths[path][method].parameters,
	values
	);
	}

I don't think I'll fix this in #82 as that's too large already. This is just a defect I found while testing #82.

[michaelgwelch]

There's some duplication between getFullPath, getQueryStrings and getHeadersArray this can probably be solved by extracting all of the common logic into one method (Probably getQueryStrings) and then have getFullPath and getHeadersArray delegate to getQueryStrings and customize as needed. For example getFullPath needs to replace a parameter place holder with an actual value.

[michaelgwelch]

Resolved in #86