fix: move playwright to thread to avoid event loop conflicts

[ErikBjare]

Fixes #351 by moving Playwright to a separate thread to isolate its event loop from prompt_toolkit.

This prevents the asyncio.run() error that occurred when trying to use prompt_toolkit after browser operations.

Changes:

• Created thread-based browser manager that keeps browser instance alive between operations
• Updated all browser operations (read_url, search, screenshot) to use the thread
• Added proper timeout and error handling
• Added browser readiness check

Tested and confirmed working with:

• read_url
• search (both Google and DuckDuckGo)
• screenshot_url
• prompt_toolkit input between operations

---

Important

Moves Playwright operations to a separate thread using BrowserThread to prevent event loop conflicts with prompt_toolkit.

• Behavior:
  • Moves Playwright operations to a separate thread using BrowserThread to prevent event loop conflicts with prompt_toolkit.
  • Adds timeout and error handling for browser operations.
  • Ensures browser readiness before operations.
• Implementation:
  • Introduces BrowserThread class in _browser_thread.py to manage browser operations in a separate thread.
  • Updates read_url, search_google, search_duckduckgo, and screenshot_url in _browser_playwright.py to use BrowserThread.
• Testing:
  • Confirms functionality with read_url, search (Google and DuckDuckGo), and screenshot_url.
  • Verifies prompt_toolkit input works between operations.

^{This description was created by for 5673f4d. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to ee322c1 in 1 minute and 22 seconds

More details

• Looked at 290 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. gptme/tools/_browser_thread.py:71

• Draft comment:
  Ensure that browser is defined before attempting to close it. If sync_playwright().start() or playwright.chromium.launch() fails, browser will be undefined, leading to a potential UnboundLocalError. Consider initializing browser to None before the try block and checking if it's not None before calling close().
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_Q9EY13Rw3y4icFq7

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Consider adding error handling for the BrowserThread initialization in get_browser(). If BrowserThread fails to start, it might raise an exception, which should be caught and logged appropriately.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 52.50000% with 57 lines in your changes missing coverage. Please review.

Project coverage is 71.03%. Comparing base (0ecf045) to head (5673f4d).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
gptme/tools/_browser_thread.py	51.25%	39 Missing ⚠️
gptme/tools/_browser_playwright.py	55.00%	18 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   72.09%   71.03%   -1.06%     
==========================================
  Files          67       68       +1     
  Lines        5132     5224      +92     
==========================================
+ Hits         3700     3711      +11     
- Misses       1432     1513      +81     

Flag	Coverage Δ
anthropic/claude-3-haiku-20240307	69.27% <52.50%> (-1.03%)	⬇️
openai/gpt-4o-mini	68.01% <52.50%> (-1.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ellipsis-dev]

❌ Changes requested. Incremental review on 5673f4d in 51 seconds

More details

• Looked at 290 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_VaODCnWXYLf5uYTZ

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ErikBjare]

Crazy how this entire thing was done by Bob!

Just gave him the issue reference, had to question his choice of process/thread/eventloop, and then off he went!