Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added deepseek support #180

Merged
merged 1 commit into from
Oct 27, 2024
Merged

feat: added deepseek support #180

merged 1 commit into from
Oct 27, 2024

Conversation

ErikBjare
Copy link
Owner

@ErikBjare ErikBjare commented Oct 9, 2024

#170


Important

Added support for deepseek provider across initialization and provider handling functions.

  • Behavior:
    • Added support for deepseek provider in init() in llm_openai.py.
    • Updated _client_to_provider() in llm.py to recognize deepseek.
    • Modified get_provider() in llm_openai.py to return deepseek.
  • Models:
    • Added deepseek to Provider and PROVIDERS_OPENAI in models.py.

This description was created by Ellipsis for e3dfd5c. It will automatically update as commits are pushed.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.29%. Comparing base (cea30cf) to head (e3dfd5c).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
gptme/llm_openai.py 0.00% 6 Missing ⚠️
gptme/llm.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   75.38%   75.29%   -0.10%     
==========================================
  Files          57       57              
  Lines        3604     3610       +6     
==========================================
+ Hits         2717     2718       +1     
- Misses        887      892       +5     
Flag Coverage Δ
anthropic/claude-3-haiku-20240307 74.21% <41.66%> (-0.13%) ⬇️
openai/gpt-4o-mini 73.82% <41.66%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikBjare ErikBjare force-pushed the dev/deepseek-support branch from 2488404 to e3dfd5c Compare October 27, 2024 21:00
@ErikBjare ErikBjare changed the title feat: wip deepseek support feat: added deepseek support Oct 27, 2024
@ErikBjare ErikBjare marked this pull request as ready for review October 27, 2024 21:05
@ErikBjare ErikBjare merged commit 949eaee into master Oct 27, 2024
7 checks passed
@ErikBjare ErikBjare deleted the dev/deepseek-support branch October 27, 2024 21:05
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e3dfd5c in 9 seconds

More details
  • Looked at 93 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. gptme/models.py:45
  • Draft comment:
    Ensure that the addition of 'deepseek' to PROVIDERS_OPENAI is consistent with its intended functionality and that all necessary configurations and API interactions are correctly implemented for this provider.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of 'deepseek' to the PROVIDERS_OPENAI list is consistent across the files, ensuring that the new provider is recognized and handled similarly to other providers. However, the code should be checked for any potential issues with the new provider integration.

Workflow ID: wflow_ejYOfKT6bB0UKQhF


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants