tests: update models to provider/model format #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 171f996 in 4 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. tests/test-integration.sh:7
- Draft comment:
The change toopenai/gpt-4-1106-previewis consistent with the intended update to use provider/llm format. No issues here. - Reason this comment was not posted:
Confidence changes required:0%
The change in the model name format is consistent with the intended update to use provider/llm format. This is a straightforward change and does not introduce any issues.
Workflow ID: wflow_YesKsTNsdunyRfmZ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
0xbrayo
changed the title
ErikBjare
force-pushed
the
master
branch
6 times, most recently
from
4190107 to
5a54f3e
Compare
|
Nice catch! Congrats on the first merged commit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update model name in
tests/test-integration.shtoopenai/gpt-4-1106-preview.tests/test-integration.shfromgpt-4-1106-previewtoopenai/gpt-4-1106-preview.This description was created by
for 171f996. It will automatically update as commits are pushed.