Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same file names in multiple directories with similar content #26

Open
hoene opened this issue Aug 14, 2019 · 2 comments
Open

Same file names in multiple directories with similar content #26

hoene opened this issue Aug 14, 2019 · 2 comments

Comments

@hoene
Copy link

hoene commented Aug 14, 2019

Hello Ingemar,

in multiple directories, we find files with the same filename. Sometimes, they have same content, sometimes, the content differs (see below).

This version of the files shall we use?

With best regards,

Christian

scream/code/gscream/gst-gscreamrx/gst-plugin/src$ diff ScreamRx.cpp ../../../../ScreamRx.cpp 
284c284
<     buf[1] = 205;
---
>     buf[1] = 207;


scream/code/gscream/gst-gscreamrx/gst-plugin/src$ diff -w ScreamRx.h ../../../../ScreamRx.h
30c30
< extern "C" {
---
> 
144c144
< }
---
> 


scream/code/gscream/gst-gscreamrx/gst-plugin/src$ diff -w ScreamTx.h ../../../../ScreamTx.h
6a7
> extern "C" {
50a52,53
> // Max video rampup scale as fraction of the current target bitrate
> static const float kRampUpScale = 0.2f; 
141a145
> 		float rampUpScale = kRampUpScale,
334a339
> 			float rampUpScale,
357a363
> 		float rampUpScale;
659a666
> }



scream/code/gscream/gst-gscreamrx/gst-plugin/src$ diff ScreamTx0.h ScreamTx.h 
7d6
< extern "C" {
661d659
< }


diff -w RtpQueue.cpp ../../../../RtpQueue.cpp 
.... many differences ....

diff -w RtpQueue.h ../../../../RtpQueue.h
.... many differences ....

scream/code/gscream/gst-gscreamtx/gst-plugin/src$ diff -w ScreamRx.cpp ../../../../ScreamRx.cpp 
284c284
<     buf[1] = 205;
---
>     buf[1] = 207;

@mirabilos
Copy link
Contributor

From what I can tell from recent activity, the bw-test-tool files are the latest, but I posed this question as well.

I symlinked the other files (those in gscream to those in top-level code) already, except for RtpQueue, which does seem to have three only very slightly differing implementations. (The diffs between the three of them also seem to hint that bw-test-tool is supposedly the current master copy.)

@mirabilos
Copy link
Contributor

@IngJohEricsson merged bw-test-tool into top-level, and I had already symlinked¹ gscream, so the file duplication is now mostly gone (modulo the GStreamer-caused delta in RtpQueue), so I’d close this.

① replaced by #include though because symlinks seem to not work with some git implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants